After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 503249 - Add GIF support
Add GIF support
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal enhancement
: 0.10.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-12-12 11:56 UTC by Sebastian Dröge (slomo)
Modified: 2007-12-17 20:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ffmpeg-gif.diff (5.75 KB, patch)
2007-12-12 11:56 UTC, Sebastian Dröge (slomo)
none Details | Review
ffmpeg-gif.diff (7.36 KB, patch)
2007-12-12 12:16 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2007-12-12 11:56:12 UTC
Hi,
the attached patch adds GIF support to gst-ffmpeg. This allows encoding a video to a GIF animation and decoding GIF animations (and single pictures).

As gdkpixbufdec only allows decoding the first picture of a GIF animation (at least I couldn't decode more than the first here) the rank should maybe be marginal+1 to be higher than gdkpixbufdec.
Comment 1 Sebastian Dröge (slomo) 2007-12-12 11:56:27 UTC
Created attachment 100824 [details] [review]
ffmpeg-gif.diff
Comment 2 Sebastian Dröge (slomo) 2007-12-12 12:16:25 UTC
Created attachment 100826 [details] [review]
ffmpeg-gif.diff

With stride conversion for the muxer too.
Comment 3 Tim-Philipp Müller 2007-12-12 12:17:36 UTC
I have a patch to make gdkpixbufdec decode gif animations, but haven't applied it because GdkPixbufLoader will decode the entire animation into raw RGB frames before returning the first frame, which works fine for small smiley animations, but will just blow up if you try to watch, say, screencasts created by byzanz.

I hope the ffmpeg decoder is a bit smarter than that.
Comment 4 Sebastian Dröge (slomo) 2007-12-12 12:20:40 UTC
The ffmpeg decoder seems to decode it frame by frame.
Comment 5 Edward Hervey 2007-12-17 15:25:04 UTC
works fine, please commit !
Comment 6 Sebastian Dröge (slomo) 2007-12-17 20:38:16 UTC
2007-12-17  Sebastian Dröge  <slomo@circular-chaos.org>

        * ext/ffmpeg/gstffmpegcodecmap.c: (gst_ffmpeg_codecid_to_caps),
        (gst_ffmpeg_formatid_get_codecids),
        (gst_ffmpeg_get_codecid_longname):
        * ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_loop),
        (gst_ffmpegdemux_register):
        * ext/ffmpeg/gstffmpegmux.c: (gst_ffmpegmux_collected),
        (gst_ffmpegmux_register):
        Add GIF (animations and single images) decoding and encoding support.
        Fixes #503249.