After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 503226 - tomboy gets into infinite loop with panel size =< 16
tomboy gets into infinite loop with panel size =< 16
Status: RESOLVED FIXED
Product: tomboy
Classification: Applications
Component: General
unspecified
Other All
: Normal critical
: ---
Assigned To: Tomboy Maintainers
Tomboy Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-12-12 09:13 UTC by gytis.raciukaitis
Modified: 2008-02-27 01:30 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
Patch (880 bytes, patch)
2007-12-12 09:14 UTC, gytis.raciukaitis
none Details | Review
Coble theme to test (19.24 KB, application/x-bzip)
2008-01-14 08:37 UTC, gytis.raciukaitis
  Details
Another patch, from Dmitry K. (982 bytes, patch)
2008-02-01 15:04 UTC, Sandy Armstrong
committed Details | Review

Description gytis.raciukaitis 2007-12-12 09:13:05 UTC
Steps to reproduce:
1. Set panel size to =< 16. This can happen with some minimalistic themes
2. Run Tomboy :)
3. Tomboy gets into an infinite loop.


Stack trace:


Other information:
Comment 1 gytis.raciukaitis 2007-12-12 09:14:18 UTC
Created attachment 100814 [details] [review]
Patch

This is a crude fix by checking for panel size of 2 not 16, which is more likely to occur with certain themes. Ideally tomboy should check for gtk panel icon size and use that.
Comment 2 Sandy Armstrong 2008-01-12 14:40:06 UTC
Can you recommend a theme that allows this so I can reproduce?
Comment 3 gytis.raciukaitis 2008-01-14 08:36:15 UTC
This can be done with the pixmap based themes. Attached modified Coble theme. You have to set the panel size to lowest posible.
Comment 4 gytis.raciukaitis 2008-01-14 08:37:07 UTC
Created attachment 102795 [details]
Coble theme to test
Comment 5 Sandy Armstrong 2008-02-01 15:04:36 UTC
Created attachment 104208 [details] [review]
Another patch, from Dmitry K.

Dmitry mailed this to the list.  Haven't had a chance to test either of these patches.
Comment 6 Kevin Kubasik 2008-02-22 23:29:53 UTC
Working on this now.
Comment 7 Kevin Kubasik 2008-02-22 23:44:19 UTC
Commited a variation of this patch, as it fixes the issue.
Comment 8 Boyd Timothy 2008-02-27 01:30:36 UTC
Modifying default assignee and qa contact to be tomboy-maint@gnome.bugs.