After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 503079 - Intro key to exit edit mode
Intro key to exit edit mode
Status: RESOLVED WONTFIX
Product: f-spot
Classification: Other
Component: General
0.4.x
Other Linux
: Normal enhancement
: ---
Assigned To: F-spot maintainers
F-spot maintainers
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2007-12-11 17:44 UTC by Pedro Villavicencio
Modified: 2018-07-12 00:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
enter-leave-edit-mode.patch (751 bytes, patch)
2008-09-12 08:12 UTC, Maxxer 		needs-work Details | Review

Description Pedro Villavicencio 2007-12-11 17:44:57 UTC 
This report has been filled here:

https://bugs.launchpad.net/ubuntu/+source/f-spot/+bug/174117

"I have noticed that the intro key can be used to enter edit mode, but not to return to browse mode. Since using the mouse you can do the same action to enter and leave edit mode (double-click) it would be logical that you can do the same action too when using the keyboard (that is, pressing the intro key)."

Using f-spot version 0.4.0
Comment 1 Stephane Delcroix 2007-12-13 12:44:34 UTC 
mmm, am wondering what a "intro" key looks like...
Comment 2 Pedro Villavicencio 2007-12-13 17:29:11 UTC 
That's the "Enter" key, thanks.
Comment 3 Maxxer 2008-09-12 08:12:27 UTC 
Created attachment 118565 [details] [review]
enter-leave-edit-mode.patch
Comment 4 Ruben Vermeersch 2008-09-16 09:58:02 UTC 
Am not sure this is a good idea, I frequently hit enter in edit mode (after writing a description or adding tags), I don't want it to flip back to browse mode if I hit it one time too much.
Comment 5 Ruben Vermeersch 2010-06-24 14:47:29 UTC 
Comment on attachment 118565 [details] [review]
enter-leave-edit-mode.patch

Maintenance update: In the past we've been less than stellar in reviewing patches. As such we have a pile of patches in bugzilla which are outdated and don't apply anymore. Am currently marking all of these as "needs-work". My apologies for this.

Since I've become a maintainer of the project, I've set the personal rule of quickly reviewing all patches, to avoid that this happens again. If you (or anyone) wants to go through the trouble of updating this patch, please talk to us to figure out if it fits in the F-Spot long term roadmap.

Should you, in the future, notice a patch lingering around for too long, please notify us immediately and we'll look into it, to avoid situations like these from happening again.

You can filter these mails by searching for ###F-OLDPATCHCLEANUP###
Comment 6 André Klapper 2018-07-12 00:02:25 UTC 
F-Spot has moved to https://github.com/f-spot/f-spot/issues

If this Bugzilla ticket is still valid in a recent version of F-Spot, please feel free to post this topic as a ticket in the F-Spot project on GitHub.

Closing this report as WONTFIX as part of Bugzilla Housekeeping as we are planning to shut down GNOME Bugzilla in favor of GNOME Gitlab.