GNOME Bugzilla – Bug 503074
crosswire length should be customizable
Last modified: 2007-12-27 17:51:09 UTC
You can currently set the width/thickness of the crosswire and add a crosswire clip. However, the length of the crosswires is not customizable (The crosswires extend the full length and width of the zoom region, covering up screen contents in the process). While some users benefit from "full" crosswires, many users just need "a little extra" surrounding the mouse pointer to make the pointer easier to spot. Therefore, it would be helpful if clients could specify the length of the crosswires. Thanks!
Hmmm, this property is defined in Magnifier, so it's apply to all ZoomRegion created. I think that support per ZoomRegion is better, what do you think? BTW, I will provide a patch to be possible to set the crosswire length with the actual code base.
Joanmarie, would you like that each length (top, left, right, bottom) be controllable, like the borders?
I'm not sure I am knowledgeable enough to have an opinion on whether that should be per ZoomRegion or not. I'll leave that to you. :-) I don't think it's necessary to set each length. I think people who want cross hairs expect all four directions to be the same size. But we can go either way as far as Orca is concerned. Thanks!
Created attachment 101521 [details] [review] fix for the problem Hi Joanmarie, here is a patch for the problem. You can test it with the control-client application: #: ./control-client f 10 50 1 Where the numbers after 'f' are SIZE, LENGTH and CLIP, respectively. Best regards.
I see that it works great with the control-client -- and is very cool btw :-) However with this patch and making no changes to Orca, I can no longer enable the clip. Should I be doing something differently within Orca or should the clip settings continue to "just work"? Thanks!
The clip must continue to "just work" and in my machine it just worked. I can use the control-client app to set size and length and also Orca to set the clip.
Hmmmm.... I'm stumped then. I'm using: 1. Latest gnome-mag from trunk 2. Latest orca from trunk 3. Ubuntu Hardy Heron Without the patch to this bug, I can toggle the cross hair clip using the Orca Preferences dialog. With the patch to the this bug, I cannot toggle the cross hair clip using the Orca Preferences dialog. You're able to toggle the clip just using Orca from trunk and your patch?? I see that things work as expected when I use the control-client app.... Any hints would be greatly appreciated! :-) Thanks!
(In reply to comment #7) > Hmmmm.... I'm stumped then. I'm using: > > 1. Latest gnome-mag from trunk > 2. Latest orca from trunk > 3. Ubuntu Hardy Heron The only difference is that I'm using Ubuntu 7.10, but I really doubt that this is the problem. > > You're able to toggle the clip just using Orca from trunk and your patch?? Yes. > > I see that things work as expected when I use the control-client app.... Any > hints would be greatly appreciated! :-) Thanks! > I really don't know what can be wrong :-(
Created attachment 101549 [details] [review] improved fix for the problem This new patch improve how the crosswire is draw when the crosswire clip is off, so it's look better.
Created attachment 101686 [details] [review] improved fix for the problem This patch remove the zoom_region_repaint_pointer that is unnecessary. The places where it was called is now replaced by zoom_region_update_cursor.