GNOME Bugzilla – Bug 503073
Border-size should be definable for each side of the zoomer
Last modified: 2007-12-27 17:30:24 UTC
Currently, the border size applies to all four sides of a zoomer. Generally a border is desired for the purpose of making it easier to visually distinguish the zoom region from the rest of the screen contents. For instance, if my zoom region is on the left half of the screen, I only need a border on the right side of the zoomer. If the zoomer occupies the bottom right corner of my screen, I only need a border for the top and left sides of the zoomer. And so on. One of two things would be helpful: 1. The border should only appear where it is needed to separate the zoom region from the rest of the screen, OR 2. Clients should be able to define the border size for each side/edge of the zoomer. Thanks!
Created attachment 101404 [details] [review] provide a solution for the problem Hi Joanmarie, This patch adds new properties to the property bag and remove the old border-size. Now you have border-size-left, border-size-top, border-size-right and border-size-bottom. This patch also modifies the control-client.c code, so if you compile this application you can test it the terminal running: #: ./control-client k 10 30 40 10 Where the first numbers are in order, left, top, right and bottom. If you think that a method to change all values in a single call is important, just call on me. Best regards.
I'm still working on incorporating this into Orca, but I think this will get the job done. Would it be possible to keep border-size in place? That might be important for backwards compatibility. It would also (I would think) provide a way to change all values at once. Thanks again very much!!
Created attachment 101497 [details] [review] patch considering backwards compatibility Thanks for the comments Joanmarie. When I was sending the patch I was just thinking about backward compatibility, but doesn't imagined anything to maintain it. Your simple comment just fill this gap :-)
Thanks Carlos. This patch seems to work quite nicely.
Created attachment 101684 [details] [review] improved patch This patch update the prop_names vector and also remove the internal variable border_size, that isn't needed anymore.