After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 502913 - Always carbon-copy (cc) option does not work anymore
Always carbon-copy (cc) option does not work anymore
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.22.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Bharath Acharya
Evolution QA team
evolution[composer]
: 510283 526731 527538 530170 531145 531635 533316 534434 538934 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-12-10 20:15 UTC by Götz Waschk
Modified: 2009-04-15 18:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
evo-account-defaults-settings (1.33 KB, patch)
2008-04-15 09:32 UTC, Bharath Acharya
needs-work Details | Review
Updated fix (2.64 KB, patch)
2008-04-29 04:01 UTC, Bharath Acharya
committed Details | Review

Description Götz Waschk 2007-12-10 20:15:25 UTC
In evolution 2.21.3 on Mandriva Cooker, the options 'Always carbon-copy (cc)' and 'Always blind carbon-copy (bcc)' don't work anymore. I have the boxes checked and entered a email address, but new messages don't have the Cc: or Bcc: fields filled out.
Comment 1 Christophe Sauthier 2008-03-04 10:12:29 UTC
This bug have also been reported during the ubuntu hardy development phase (evolution 2.21.92) : https://bugs.edge.launchpad.net/evolution/+bug/198167
Comment 2 Michael R Head 2008-03-04 17:10:07 UTC
There are some peculiarities to the behavior.

1) it only seems to occur for the first account, when the first account is the default account
2) when composing the new mail, if you select another account, then re-select the default account, the fields will be populated properly
Comment 3 Michael R Head 2008-03-04 17:10:45 UTC
I'll copy my original report from LP here for upstream convenience:

I set Evolution to bcc myself on all messages. Under past releases of Evo, there was a bug #92036 that was active when emails were created via firefox links that caused the BCC default not to be used. This bug seems to have expanded to new messages created from within Evolution.

Steps to reproduce:
1) Launch evolution
2) edit the default account and set (in the account editor) a value for BCC the "always blind carbon copy to" and tick the checkbox.
3) close out of the account editor and preferences window.
4) create a new email (File/New/Mail Message)
5) note that the BCC field is empty.

I've noticed that this doesn't happen for all my accounts, just my default, main account.
It only seems to occur for the first account in the list of accounts when that account is the default account. Hopefully that will help with reproduction.

Versions: Evolution 2.21.92
evolution:
  Installed: 2.21.92-0ubuntu1
  Candidate: 2.21.92-0ubuntu1
  Version table:
 *** 2.21.92-0ubuntu1 0
        500 http://us.archive.ubuntu.com hardy/main Packages
        100 /var/lib/dpkg/status
Comment 4 C de-Avillez 2008-03-05 10:16:36 UTC
*** Bug 510283 has been marked as a duplicate of this bug. ***
Comment 5 Matthew Barnes 2008-03-11 00:35:23 UTC
Bumping version to a stable release.
Comment 6 Götz Waschk 2008-03-12 13:09:31 UTC
It was reported several times, so I think we can say it is a confirmed bug.
Comment 7 Matthew Barnes 2008-04-02 22:10:51 UTC
This seems to be working correctly in the new composer that will debut in Evolution 2.23.1.  Hoping we can fix the old code in a 2.22.x update.
Comment 8 André Klapper 2008-04-14 08:47:07 UTC
*** Bug 527538 has been marked as a duplicate of this bug. ***
Comment 9 Bharath Acharya 2008-04-15 09:32:23 UTC
Created attachment 109288 [details] [review]
evo-account-defaults-settings

This should fix the bug. But which commit actually broke this i'm not too sure. Will provide updates if i happen to notice it.
Comment 10 Götz Waschk 2008-04-15 16:07:27 UTC
to #9: I have tried your patch, it does not work. The Bcc: field is still empty when replying to a mail. But when you create a new mail, Bcc: is filled correctly.
Comment 11 Bharath Acharya 2008-04-16 03:30:47 UTC
Oops didn't notice that scenario as "Replying to a mail" wasn't mentioned in any of the comments. Will update with a new patch in here. Thanks for trying the patch.
Comment 12 Srinivasa Ragavan 2008-04-16 08:50:03 UTC
Setting the status accordingly.
Comment 13 André Klapper 2008-04-27 16:18:32 UTC
*** Bug 530170 has been marked as a duplicate of this bug. ***
Comment 14 Bharath Acharya 2008-04-29 04:01:26 UTC
Created attachment 110079 [details] [review]
Updated fix

This should fix all issues. 

Matthew, this would not occur in the new composer as you have switched to EComposerHeaderTable :)
Comment 15 Matthew Barnes 2008-04-29 05:00:23 UTC
Looks correct, please commit to stable.  Thanks!
Comment 16 Bharath Acharya 2008-04-29 06:02:11 UTC
Committed to Stable branch gnome-2-22 as r35434
http://svn.gnome.org/viewvc/evolution?view=revision&revision=35434
Comment 17 Susana 2008-05-03 12:08:24 UTC
*** Bug 531145 has been marked as a duplicate of this bug. ***
Comment 18 André Klapper 2008-05-07 09:01:11 UTC
*** Bug 531635 has been marked as a duplicate of this bug. ***
Comment 19 andebr 2008-05-15 17:18:27 UTC
*** Bug 533316 has been marked as a duplicate of this bug. ***
Comment 20 Matthew Barnes 2008-05-23 02:46:07 UTC
*** Bug 526731 has been marked as a duplicate of this bug. ***
Comment 21 Matthew Barnes 2008-05-23 02:46:23 UTC
*** Bug 534434 has been marked as a duplicate of this bug. ***
Comment 22 Matthew Barnes 2008-06-18 19:02:00 UTC
*** Bug 538934 has been marked as a duplicate of this bug. ***
Comment 23 Øystein Gisnås 2008-10-26 16:32:10 UTC
It seems as if the fix in 2.22.3.1 deals with BCC, but not with CC when pressing "reply to". Could someone confirm that? Even though the composer has been remade, several distributions have stable releases with 2.22.3.1, and I would appreciate if someone could suggest a fix.

This bug is also reported at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=479533
Comment 24 Bob Blanchard 2009-04-06 22:19:07 UTC
This should *not* be marked as resolved, since the "CC" is still not working on reply, and that is the subject of this bug report.
( I cannot seem to find any upstream patches that fix this!  If there is - a link to this bug would be appreciated! )
  
The patch in r35434 fixes for "BCC" only.

Patching for reply is easy, but doesn't work for "reply to all" (ie. it over-writes the "CC" list.)

--- em-composer-utils.c.r35434	2009-04-06 18:09:35.000000000 -0400
+++ em-composer-utils.c	2009-04-06 15:54:32.000000000 -0400
@@ -1440,7 +1440,7 @@
 
 	e_msg_composer_hdrs_set_from_account (hdrs, account?account->name:NULL);
 	e_msg_composer_hdrs_set_to (hdrs, tov);
-	e_msg_composer_hdrs_set_cc (hdrs, ccv); 
+	/* e_msg_composer_hdrs_set_cc (hdrs, ccv); */
 	e_msg_composer_hdrs_set_subject (hdrs, subject);
 
 	g_free (subject);

Any patch suggestions?

Comment 25 Matthew Barnes 2009-04-06 23:48:30 UTC
(In reply to comment #24)
> This should *not* be marked as resolved, since the "CC" is still not working
> on reply, and that is the subject of this bug report.

It's fixed in later releases, and we're no longer supporting 2.22.
Comment 26 Bill Helfinstine 2009-04-15 18:01:28 UTC
It appears that this bug still exists in 2.24.5 and 2.26.1.  The "Always blind carbon-copy" option _does_ work correctly, but the "Always carbon-copy" option only works on new messages, and does not work correctly when replying to a message.

This appears to be due to the call to e_composer_header_table_set_destinations_cc in the reply_get_composer function.  The composer has already filled in the values from the two "Always..." options in update_auto_recipients, but the CC line gets overwritten and the BCC line does not.  

It looks like the reply code needs to merge the CC destinations in, rather than just resetting them.