After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 502771 - Fix MTP transcoding issues
Fix MTP transcoding issues
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Removable Media
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 475074 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-12-10 03:07 UTC by Matt N
Modified: 2008-07-25 12:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
FIx against current svn head (1.50 KB, patch)
2007-12-10 03:09 UTC, Matt N 		none Details | Review
long overdue patch (11.93 KB, patch)
2008-04-12 14:29 UTC, Jonathan Matthew 		committed Details | Review

Description Matt N 2007-12-10 03:07:56 UTC 
When current HEAD tries to transfer a file to a device, and has to transcode it, it reports the file size of the original file to libmtp, which results in an error, and makes RB unable to transfer any tracks it has to transcode.

This patch fixes that, and updates the code to use the LIBMTP_Get_Tracklisting_With_Callback function instead of the deprecated LIBMTP_Get_Tracklisting.
Comment 1 Matt N 2007-12-10 03:09:56 UTC 
Created attachment 100672 [details] [review]
FIx against current svn head
Comment 2 Jonathan Matthew 2007-12-11 11:49:42 UTC 
Thanks for tracking this down.

I think it'd be better to fix this by having the encoder include the size of the output file in its 'completed' signal, since it's likely that this same issue will come up with other similar plugins.
Comment 3 Matt N 2007-12-11 21:56:32 UTC 
I have no idea how to do that....
Comment 4 Jonathan Matthew 2007-12-11 23:01:02 UTC 
I'm doing it.  Unsuccessfully so far, but I'm doing it.
Comment 5 Jonathan Matthew 2008-03-05 10:43:43 UTC 
*** Bug 475074 has been marked as a duplicate of this bug. ***
Comment 6 Jonathan Matthew 2008-04-12 14:29:49 UTC 
Created attachment 109120 [details] [review]
long overdue patch

In the end, I gave up on getting the transcoding pipeline to give me the size of the output file directly, and just used gnome-vfs to get it.
Comment 7 Jonathan Matthew 2008-06-07 02:35:55 UTC 
I've committed the patch, but as far as I know it hasn't been tested.  If someone could confirm that it works, or reopen the bug if it doesn't, that'd be great..
Comment 8 Jonas Meyer 2008-07-25 12:40:11 UTC 
the patch works for me. I haven't tried after the commit, though.