After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 501485 - totem menu items are not localized
totem menu items are not localized
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
unspecified
Other opensolaris
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-12-04 11:22 UTC by Takao Fujiwara
Modified: 2007-12-06 03:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for data/totem.ui and src/plugins/skipto/totem-skipto-plugin.c (1.75 KB, patch)
2007-12-04 11:36 UTC, Takao Fujiwara 		accepted-commit_now Details | Review

Description Takao Fujiwara 2007-12-04 11:22:10 UTC 
totem menu items are not localized because totem.ui does not have 'translatable' attribute.

I'm attaching the patch.
Comment 1 Takao Fujiwara 2007-12-04 11:36:00 UTC 
Created attachment 100172 [details] [review]
Patch for data/totem.ui and src/plugins/skipto/totem-skipto-plugin.c

It seems some UI labels were updated to fix this issue recently however other labels are not fixed yet so I'ld like to fix all UI labels in totem.ui

I also fixes skipto plugin to set the textdomain.

Could you review the patch?

BTW, is it possible to rename totem.ui to totem.glade?
po/POTFILES.in specifies the totem.ui is the glade file however one problem is, it seems some .po files does not have the strings of totem.ui. When translators try to generate the POTFILES.in from the scrach, the file is not detected.

% cd po
% echo > POTFILES.in
% intltool-update -m
Comment 2 Philip Withnall 2007-12-05 22:31:14 UTC 
(In reply to comment #1)
> Created an attachment (id=100172) [edit]
> Patch for data/totem.ui and src/plugins/skipto/totem-skipto-plugin.c
> 
> It seems some UI labels were updated to fix this issue recently however other
> labels are not fixed yet so I'ld like to fix all UI labels in totem.ui
> 
> I also fixes skipto plugin to set the textdomain.
> 
> Could you review the patch?

Looks good; please commit.

> BTW, is it possible to rename totem.ui to totem.glade?
> po/POTFILES.in specifies the totem.ui is the glade file however one problem is,
> it seems some .po files does not have the strings of totem.ui. When translators
> try to generate the POTFILES.in from the scrach, the file is not detected.
> 
> % cd po
> % echo > POTFILES.in
> % intltool-update -m

Works fine for me, and all the data/*.ui files are detected as needing translation. I presume it's just treating them as glade files, as they're pretty similar at the moment, and since no translation contexts are used in them (see bug #454894) there's hopefully no difference as far as intltool's concerned.
Comment 3 Takao Fujiwara 2007-12-06 03:45:32 UTC 
> Works fine for me, and all the data/*.ui files are detected as needing

You're right. I mistook it.

Thanks for the review. Commited the patch.

2007-12-06  Takao Fujiwara  <takao.fujiwara@sun.com>

    reviewed by: Philip Withnall

    * data/totem.ui:
      Mark messages for translation.
    * src/plugins/skipto/totem-skipto-plugin.c:
      (totem_galago_plugin_finalize): Set translation domain.
      (Closes: #501485)