GNOME Bugzilla – Bug 501165
Support for host::port
Last modified: 2008-05-07 17:06:45 UTC
Normal vnc has support for host::port but vinarge is not allowing it. It is sometime useful to have this feature when port forwarding is used over ssh Other information:
This has been a problem for me too. I have port-forwarding setup and use VNC to connect to some ports out of the usual VNC number range. Vinaigre doesn't seem to allow this.
Hi. I can't understand why not supporting host::port syntax could be an issue for you. You are able to use the host:port syntax anyway.
Most of VNC client have support for vnc screen number or absolute port number. vnc server is running on port 5901 I can do: vncviewer <server>:1 I have port forwarding and local port 10001 forwarded to server port 5900 where vnc is running, I can do : vncviewer <server>::10001 I tested vinagre and it work for case #2 put doesn't work with case number #1. Also when I tried to test case #1 (vinagre serever:1), vinagre started and took control of mouse while it was waiting for server and I was not able to release mouse by pressing ctrl+alt keys which kinda seems like frozen system.
Here is a patch that makes Vinagre treat port numbers below 1025 as VNC screen numbers 0- (5900-).Caveat is of course if/when Vinagre will support other protocols then this should be only performed for VNC of course.
Created attachment 110447 [details] [review] patch for treating port numbers below 1025 as vnc display
Hi, Henrik. I like this approach. Could you improve the patch to the following stream: - If the uri is host::port, handle the port as port. - If the url is host:port, handle the port as display if it is less than 1024 (You're already doing this) Thanks.
Created attachment 110457 [details] [review] handles : and :: differently now Here is a patch that handles :: as an absolut port marker and : as display port for ports under 1024 as you requested.
Thanks, Henrik. Patch committed. 2008-05-06 Jonh Wendell <jwendell@gnome.org> * src/vinagre-connection.c: Support for host::port, patch from Henrik Holst, closes #501165.
Thanks Henrik and Jonh.