After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 501165 - Support for host::port
Support for host::port
Status: RESOLVED FIXED
Product: vinagre
Classification: Applications
Component: general
0.3
Other All
: Normal minor
: ---
Assigned To: vinagre-maint
vinagre-maint
Depends on:
Blocks:
 
 
Reported: 2007-12-03 06:18 UTC by sharmay
Modified: 2008-05-07 17:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for treating port numbers below 1025 as vnc display (378 bytes, patch)
2008-05-06 09:13 UTC, Henrik Holst
needs-work Details | Review
handles : and :: differently now (769 bytes, patch)
2008-05-06 12:41 UTC, Henrik Holst
committed Details | Review

Description sharmay 2007-12-03 06:18:00 UTC
Normal vnc has support for host::port but vinarge is not allowing it. It is sometime useful to have this feature when port forwarding is used over ssh

Other information:
Comment 1 Steven Garrity 2008-02-02 17:56:04 UTC
This has been a problem for me too. I have port-forwarding setup and use VNC to connect to some ports out of the usual VNC number range. Vinaigre doesn't seem to allow this. 
Comment 2 Jonh Wendell 2008-02-06 15:47:19 UTC
Hi.

I can't understand why not supporting host::port syntax could be an issue for you. You are able to use the host:port syntax anyway.
Comment 3 sharmay 2008-02-12 15:06:54 UTC
Most of VNC client have support for vnc screen number or absolute port number.

vnc server is running on port 5901 I can do:
vncviewer <server>:1

I have port forwarding and local port 10001 forwarded to server port 5900 where vnc is running, I can do :

vncviewer <server>::10001

I tested vinagre and it work for case #2 put doesn't work with case number #1.

Also when I tried to test case #1 (vinagre serever:1), vinagre started and took control of mouse while it was waiting for server and I was not able to release mouse by pressing ctrl+alt keys which kinda seems like frozen system.
Comment 4 Henrik Holst 2008-05-06 09:10:48 UTC
Here is a patch that makes Vinagre treat port numbers below 1025 as VNC screen numbers 0- (5900-).Caveat is of course if/when Vinagre will support other protocols then this should be only performed for VNC of course.
Comment 5 Henrik Holst 2008-05-06 09:13:34 UTC
Created attachment 110447 [details] [review]
patch for treating port numbers below 1025 as vnc display
Comment 6 Jonh Wendell 2008-05-06 12:08:49 UTC
Hi, Henrik.

I like this approach. Could you improve the patch to the following stream:

- If the uri is host::port, handle the port as port.
- If the url is host:port, handle the port as display if it is less than 1024 (You're already doing this)

Thanks.
Comment 7 Henrik Holst 2008-05-06 12:41:07 UTC
Created attachment 110457 [details] [review]
handles : and :: differently now

Here is a patch that handles :: as an absolut port marker and : as display port for ports under 1024 as you requested.
Comment 8 Jonh Wendell 2008-05-06 13:02:02 UTC
Thanks, Henrik. Patch committed.

2008-05-06  Jonh Wendell <jwendell@gnome.org>

	* src/vinagre-connection.c: Support for host::port, patch from
	Henrik Holst, closes #501165.
Comment 9 sharmay 2008-05-07 17:06:45 UTC
Thanks Henrik and Jonh.