GNOME Bugzilla – Bug 500930
Move the Tools dialog to the Toolbox tab in preferences
Last modified: 2009-08-01 14:28:10 UTC
The topic of moving the Tools dialog box to the Toolbox tab in Preferences was discussed amonst the GIMP developers on IRC (and/or the mailing list). Adding this report so the idea doesn't get forgotten.
Setting to NEW and adding gnome-love keyword. This could easily be done by someone who wants to get started on GIMP development.
If this is supposed to be handled as a gnome-love bug, then we should add some words on the motivation of this change. The Tools dockable allows to reorder the tools in the toolbox and it allows to show/hide tools (see http://docs.gimp.org/en/gimp-dialogs-misc.html#gimp-tools-dialog). That makes it a configuration dialog. Thus it should better be accessible from the Preferences dialog, perhaps from the tab labeled "Toolbox".
Created attachment 137629 [details] pref dialog screenshot. here is the picture requested.
The tools area should use all of the the vertical space that is available.
cool that you are working on this. I am sure that you will work the vertical issue out what I would like to see (as guiguru, not as a user) is at least a title (like "Tools configuration") with some natural margin above it to separate it from those 3 checkboxes above.
Created attachment 137678 [details] [review] makes toolview a standalone widget this is the current patch, I don't know how close to finished it is or if it is the right approach. Better to find out now I guess
after having a look at the existing Tools dialog, I actually conclude that it belongs in the Edit menu, right below Keyboard shortcuts as a non-dockable dialog. this additional to the placement in the preferences. having it in both places makes it findable in the most obvious spots (not a bad thing).
Is it really worth keeping all this in the Edit menu? One could probably argue that pretty much all settings that are currently in the Preferences would be easier to locate if they would be duplicated in other places. But doesn't this lead to total menu overload? I didn't look at the patch in detail, but it looks good on first sight. I just wonder if the widget should perhaps be called GimpToolsEditor instead of GimpToolView ?
Created attachment 137775 [details] [review] two patches creating and using GimpToolEditor, from GimpToolView here are two patches, now using gimp container tree view as mitch advised. *two patches so the file rename gets recorded by git properly *this does not yet implement the second dialog suggested by guiguru
Created attachment 137776 [details] as above as above, marked tar file as a patch, correcting.
Created attachment 137870 [details] [review] patch 1 first of two
Created attachment 137871 [details] [review] second of two these two patches remove the old funcs for toolview create tool editor and use it with: preferencese dialog and tools configuration dialog.
Let's make sure to do this for 2.8.
I split up your commits in nicer self-contained chunks and pushed to git master. Shit, I just noticed I accidentally set myself as Author in the last two commits :( Sorry about that. Anywhere the commits are: commit 4572cb9e74941330357f6872a50bca777677970d Author: Martin Nordholts <martinn@src.gnome.org> app: Add the GimpToolEditor to preferences commit ce5cfe0f1c14ca44aad3024c31991cb79aae00ef Author: Martin Nordholts <martinn@src.gnome.org> app: Rename gimptoolview.[ch] to gimptooleditor.[ch] commit 450db18abb57f540889eb38f1c13297bedbd4c10 Author: Stephen Griffiths <scgmk5@gmail.com> app: Convert GimpToolView into a non-dockable GimpToolEditor commit c53113d0cca31f8a106791977363d6b0d34aa1e5 Author: Stephen Griffiths <scgmk5@gmail.com> app: Remove Tools dockable The only thing we need to do now before we can close this bug report is making tool rearrangements cancellable when the Cancel button in Preferences is pressed.
I am not worried about who is listed as the author :), I will start working on making the tool re-arrangement cancellable on the weekend.
Created attachment 139058 [details] [review] use new buttons instead of shift+click Enselic suggested in irc that shift+click (raise to top and lower to bottom) is not very discoverable, and buttons should be added instead. this patch implements that suggestion.
I don't see why these up/down buttons would do it differently than the ones in the layers/channels/paths dialogs. I'm not totally sure here, but aren't the buttons just something that has to be there because the actual way of reordering (DND) is not very discoverable either?
My mistake, adding those buttons doesn't make sense, sorry for the wasted hacking :(
Created attachment 139466 [details] [review] Make gimptooleditor changes cancellable and use that.
Looks nice, but you need to add a finalizer and free the name array there.
Created attachment 139602 [details] [review] make GimpToolEditor changes cancellable. UPDATED previous patch to free string array as suggested.
Thanks, but it only resets the order of the tools, not their visibility, which it also needs to do. Other than that, the patch looks fine to me.
Created attachment 139689 [details] [review] make GimpToolEditor changes cancellable. (updated again) Thanks Martin I did not even think about visibility.
Thanks, seems to work fine now, I've pushed the commit to master after making some name changes that IMO gives clearer semantics: commit 6a41c872f628fc30ceb9fa02299824f06f76e088 Author: Stephen Griffiths <scgmk5@gmail.com> Date: Wed Jul 29 21:55:31 2009 +1000 app: Make GimpToolEditor changes cancellable Allow the user to cancel rearrangements of tool order and visibility in Preferences. See enhancement request/bug #500930. app/dialogs/preferences-dialog.c | 21 ++++--- app/widgets/gimptooleditor.c | 116 +++++++++++++++++++++++++++++++++----- app/widgets/gimptooleditor.h | 14 +++-- 3 files changed, 120 insertions(+), 31 deletions(-) we can now consider this FIXED and deal with any other issues that pop up in separate bug reports.