GNOME Bugzilla – Bug 500655
GDM crashes when trying to bring up chooser
Last modified: 2007-11-30 18:59:06 UTC
(from https://bugzilla.redhat.com/show_bug.cgi?id=403961) Philippe Troin noticed a crash when using the XDMCP button in the circles theme. 1. Set up gdm with a theme that display the remote login button (eg. circles) as the default theme is very limited (ahem). 2. Click on "Remote login via XDMCP" 3. Pick a host that runs XDMCP 4. See gdm crash 5. The following is logged: kernel: gdm-binary[10567]: segfault at 000004d0 eip 00885328 esp bf922a80 error 4 gdm-binary[10350]: WARNING: gdm_cleanup_children: child 10567 crashed of signal 11 gdm-binary[10350]: WARNING: gdm_cleanup_children: Slave crashed, killing its children He attached a patch that fixed the problem for him.
Created attachment 99908 [details] [review] patch that made crash go away
Philippe, does this patch make XDMCP work or just stop the crash? I'm a little confused as to why display is NULL in the gdm_get_current_vtnum () call. We only make that call once, in slave.c, and at that point, the only way d->dsp could be NULL is if XOpenDisplay failed, but we already do gdm_slave_quick_exit (DISPLAY_ABORT); if d->dsp is NULL earlier.
Ray, note that this has already been fixed in 2.20.2. I wrote the exact same change on 11-13-2007.
oh okay, I'll just push a 2.20.2 update to F8.
Ray, Since you're pushing 2.20.2 to F8, would you mind adding the Suspend patch from RH Bugzilla #387001 (Gnome Bugzilla #500362)? Phil.
yup, sure.