After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 500496 - The totem-browser play button is constantly redrawing itself
The totem-browser play button is constantly redrawing itself
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Browser plugin (obsolete)
unspecified
Other All
: Normal normal
: ---
Assigned To: totem-browser-maint
totem-browser-maint
Depends on:
Blocks:
 
 
Reported: 2007-11-29 19:36 UTC by iain
Modified: 2007-12-11 18:26 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
Video showing the totem button redrawing itself using Metacity-compositor hack to colour in redrawn screen regions a funny colour (25.62 KB, application/ogg)
2007-11-29 19:38 UTC, iain
Details

Description iain 2007-11-29 19:36:56 UTC
Please describe the problem:
Watch the attached video. This is Metacity drawing a different coloured overlay every time a region of the screen gets redrawn. In the bottom left corner the totem-browser button is constantly being redrawn even though the movie is not playing, and the mouse is not near it (Mouse pointer can be seen at the top right of the screen)


Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 iain 2007-11-29 19:38:10 UTC
Created attachment 99861 [details]
Video showing the totem button redrawing itself using Metacity-compositor hack to colour in redrawn screen regions a funny colour
Comment 2 Bastien Nocera 2007-11-29 19:47:37 UTC
Yep, that's normal. It's to attract your attention. Did you check what it does without the pink glasses on? :)

You can also disable-animations in GTK, it won't redraw then.
Comment 3 iain 2007-11-29 20:28:17 UTC
Why is it normal for the button to redraw itself constantly?
Comment 4 Bastien Nocera 2007-11-29 21:22:04 UTC
Because it's blinking, asking for attention, just the same way the one of the taskbar's items might be blinking if an application is asking for attention.

You just opened a movie in your web browser, you need to press the play button to play, this is where the button is. Otherwise people wonder why it never starts playing. See bug #447363 for the background.
Comment 5 iain 2007-11-30 01:31:51 UTC
Ohhhh, i've never seen that before. Sorry for wasting your time, although honestly, in all the time I've been using totem (and I use it every day) I've never ever noticed that before.

It clearly doesn't ask for attention enough...Maybe you should have a big animated arrow pointing at it as well...and a sample that says "Oi! Click the bloody button!"

Then I'd notice it.
Comment 6 Mart Raudsepp 2007-12-11 12:06:20 UTC
Does it also stop glowing on and off and leave to on after a while, like it does 2.20's taskbar (after 3 or 5 glows it remains on), to not keep waking up the CPU if the user went away and not seeing the glowing on/off?
Comment 7 Bastien Nocera 2007-12-11 17:36:26 UTC
(In reply to comment #5)
> Ohhhh, i've never seen that before. Sorry for wasting your time, although
> honestly, in all the time I've been using totem (and I use it every day) I've
> never ever noticed that before.

It's only in the browser plugin.

(In reply to comment #6)
> Does it also stop glowing on and off and leave to on after a while, like it
> does 2.20's taskbar (after 3 or 5 glows it remains on), to not keep waking up
> the CPU if the user went away and not seeing the glowing on/off?

Makes sense.
Comment 8 Bastien Nocera 2007-12-11 18:26:43 UTC
2007-12-11  Bastien Nocera  <hadess@hadess.net>

        * browser-plugin/totem-glow-button.c: (totem_glow_button_glow),
        (totem_glow_button_enter), (totem_glow_button_leave):
        Only glow 4 times, even if we don't get the pointer entering,
        Fix the glow being slower, not faster when the pointer enters
        (Closes: #500496)

2007-12-11  Bastien Nocera  <hadess@hadess.net>

        * browser-plugin/totem-glow-button.c: (totem_glow_button_glow),
        (take_screenshot), (copy_pixmap), (totem_glow_button_expose):
        Backport patch from Ryan Lortie <desrt@desrt.ca> from libwnck,
        Makes use of Cairo instead of GdkPixbuf for copying the pixmaps,
        see bug #439417 for details