After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 500099 - Fixes and improvements to souphttpsrc
Fixes and improvements to souphttpsrc
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-11-28 01:25 UTC by Wouter Cloetens
Modified: 2007-11-29 10:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Various fixes and improvements. (12.91 KB, patch)
2007-11-28 01:26 UTC, Wouter Cloetens 		committed Details | Review

Description Wouter Cloetens 2007-11-28 01:25:00 UTC 
Please describe the problem:
The async HTTP source added in bug 497020 had some issues:
- GMainContext object is leaked,
- libsoup does not support async client operation prior to version 2.2.104,
- libsoup < 2.2.104 has some leak issues,
- unlock() is not implemented.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Wouter Cloetens 2007-11-28 01:26:37 UTC 
Created attachment 99748 [details] [review]
Various fixes and improvements.

This patch to CVS HEAD also:
- fixes some source formatting inconsistency,
- picks up the size from the Content-Length header and emits a duration message.
Comment 2 Wim Taymans 2007-11-29 10:49:22 UTC 
        Patch by: Wouter Cloetens <wouter at mind dot be>

        * configure.ac:
        Bump libsoup requirement as libsoup does not support async client 
        operation prior to version 2.2.104 and it has some leaks.

        * ext/soup/gstsouphttpsrc.c: (gst_souphttp_src_class_init),
        (gst_souphttp_src_init), (gst_souphttp_src_dispose),
        (gst_souphttp_src_set_property), (gst_souphttp_src_create),
        (gst_souphttp_src_start), (gst_souphttp_src_stop),
        (gst_souphttp_src_unlock), (gst_souphttp_src_unlock_stop),
        (gst_souphttp_src_get_size), (soup_got_headers), (soup_got_body),
        (soup_finished), (soup_got_chunk), (soup_response),
        (soup_session_close):
        * ext/soup/gstsouphttpsrc.h:
        Implement unlock().
        Picks up the size from the Content-Length header and emit a duration
        message.
        Don't leak the GMainContext object.
        Fixes #500099.