Bug 499744 – make yelp build against xulrunner 1.9

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 499744 - make yelp build against xulrunner 1.9


Summary:	make yelp build against xulrunner 1.9


Status:	RESOLVED FIXED

Product:	yelp
Classification:	Applications
Component:	General
Version:	git master
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Yelp maintainers
QA Contact:	Yelp maintainers

URL:
Whiteboard:

Duplicates:	484991 (view as bug list)
Depends on:
Blocks:	356041

Reported:	2007-11-26 14:35 UTC by Matthias Clasen
Modified:	2008-07-14 07:49 UTC

See Also:
GNOME target:	---
GNOME version:	2.23/2.24

Attachments
yelp-2.20.0-xulrunner.patch (802 bytes, patch) 2007-11-26 14:38 UTC, Matthias Clasen	none	Details \| Review
xulrunner-1.9b1 (25.30 KB, patch) 2007-12-02 23:56 UTC, Florian Steinel	none	Details \| Review
xulrunner1.9 patch from Alexander Sack (15.10 KB, patch) 2007-12-10 17:21 UTC, Sebastien Bacher	none	Details \| Review
updated patch, builds with xr1.9 and ff2.0/xr1.8 (18.33 KB, patch) 2008-04-02 18:01 UTC, Christian Persch	committed	Details \| Review

Description Matthias Clasen 2007-11-26 14:35:36 UTC

Here is a patch we needed

Comment 1 Matthias Clasen 2007-11-26 14:38:59 UTC

Created attachment 99663 [details] [review]
yelp-2.20.0-xulrunner.patch

Comment 2 Florian Steinel 2007-12-02 22:09:13 UTC

also sync files gecko.m4 and libxul.m4 from epiphany/m4/ (see Bug #329429 )

Comment 3 Florian Steinel 2007-12-02 23:56:15 UTC

Created attachment 100075 [details] [review]
xulrunner-1.9b1

First try to build yelp with libxul, output:
make[3]: Entering directory `/var/tmp/portage/gnome-extra/yelp-2.20.0/work/yelp-2.20.0/src'
i686-pc-linux-gnu-g++ -DHAVE_CONFIG_H -I. -I..  -I.. -I../src  -I/usr/include/xulrunner-1.9b1/stable -I/usr/include/xulrunner-1.9b1/unstable -DG_LOG_DOMAIN=\"Yelp\" -DPREFIX=\""/usr"\" -DSYSCONFDIR=\""/etc"\" -DDATADIR=\""/usr/share"\" -DLIBDIR=\""/usr/lib"\" -DIMAGEDIR=\""/usr/share/images/yelp"\" -DSERVERDIR=\"/usr/libexec\" -DBINDIR=\""/usr/bin"\" -DSHAREDIR=\""/usr/share/yelp"\" -DMOZILLA_HOME=\""/usr/lib/xulrunner-1.9b1\"" -DGDU_ICON_PATH=\"/usr/share/gnome-doc-utils/icons\"   -DORBIT2=1 -pthread -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-unix-print-2.0 -I/usr/include/gtk-2.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/lib/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/libglade-2.0 -I/usr/include/libxml2 -I/usr/include/libgnome-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/libgnomeui-2.0 -I/usr/include/libart-2.0 -I/usr/include/gnome-keyring-1 -I/usr/include/libbonoboui-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/gail-1.0 -I/usr/include/startup-notification-1.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/rarian     -O2 -march=athlon -funroll-loops -pipe -ggdb -Wall -Wno-unused  -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -O2 -march=athlon -funroll-loops -pipe -ggdb -MT yelp-Yelper.o -MD -MP -MF .deps/yelp-Yelper.Tpo -c -o yelp-Yelper.o `test -f 'Yelper.cpp' || echo './'`Yelper.cpp
In file included from /usr/include/xulrunner-1.9b1/stable/nsXPCOMStrings.h:42,
                 from /usr/include/xulrunner-1.9b1/stable/nsStringAPI.h:52,
                 from Yelper.cpp:28:
/usr/include/xulrunner-1.9b1/stable/nscore.h:51:21: error: prtypes.h: No such file or directory
In file included from /usr/include/xulrunner-1.9b1/stable/nsStringAPI.h:53,
                 from Yelper.cpp:28:
/usr/include/xulrunner-1.9b1/stable/nsISupportsImpl.h:55:60: error: prthread.h: No such file or directory
/usr/include/xulrunner-1.9b1/stable/nsISupportsImpl.h:56:81: error: pratom.h: No such file or directory
In file included from Yelper.cpp:28:
/usr/include/xulrunner-1.9b1/stable/nsStringAPI.h:54:19: error: prlog.h: No such file or directory
In file included from /usr/include/xulrunner-1.9b1/unstable/cairo-features.h:40,
                 from /usr/include/xulrunner-1.9b1/unstable/cairo.h:41,
                 from /usr/include/gtk-2.0/gdk/gdkcolor.h:30,
                 from /usr/include/gtk-2.0/gdk/gdkcairo.h:23,
                 from /usr/include/gtk-2.0/gdk/gdk.h:30,
                 from /usr/include/gtk-2.0/gtk/gtk.h:31,
                 from /usr/include/xulrunner-1.9b1/unstable/gtkmozembed.h:51,
                 from Yelper.cpp:30:
/usr/include/xulrunner-1.9b1/unstable/cairo-platform.h:40:22: error: prcpucfg.h: No such file or directory
In file included from Yelper.cpp:30:
/usr/include/xulrunner-1.9b1/unstable/gtkmozembed.h:62:1: warning: "NS_HIDDEN" redefined
In file included from /usr/include/xulrunner-1.9b1/stable/nsXPCOMStrings.h:42,
                 from /usr/include/xulrunner-1.9b1/stable/nsStringAPI.h:52,
                 from Yelper.cpp:28:
/usr/include/xulrunner-1.9b1/stable/nscore.h:117:1: warning: this is the location of the previous definition
In file included from Yelper.cpp:30:
/usr/include/xulrunner-1.9b1/unstable/gtkmozembed.h:68:1: warning: "NS_EXPORT_" redefined
In file included from /usr/include/xulrunner-1.9b1/stable/nsXPCOMStrings.h:42,
                 from /usr/include/xulrunner-1.9b1/stable/nsStringAPI.h:52,
                 from Yelper.cpp:28:
/usr/include/xulrunner-1.9b1/stable/nscore.h:208:1: warning: this is the location of the previous definition
In file included from Yelper.cpp:30:
/usr/include/xulrunner-1.9b1/unstable/gtkmozembed.h:69:1: warning: "NS_IMPORT_" redefined
In file included from /usr/include/xulrunner-1.9b1/stable/nsXPCOMStrings.h:42,
                 from /usr/include/xulrunner-1.9b1/stable/nsStringAPI.h:52,
                 from Yelper.cpp:28:
/usr/include/xulrunner-1.9b1/stable/nscore.h:206:1: warning: this is the location of the previous definition
In file included from /usr/include/xulrunner-1.9b1/unstable/nsISupports.h:10,
                 from /usr/include/xulrunner-1.9b1/unstable/nsIWebBrowser.h:10,
                 from /usr/include/xulrunner-1.9b1/unstable/gtkmozembed_internal.h:43,
                 from Yelper.cpp:31:
/usr/include/xulrunner-1.9b1/unstable/nsrootidl.h:12:20: error: prtime.h: No such file or directory

Comment 4 Sebastien Bacher 2007-12-10 17:21:23 UTC

Created attachment 100701 [details] [review]
xulrunner1.9 patch from Alexander Sack

The patch is from Alexander Sack and has been uploaded to Ubuntu today, it adds libxul-embedding to the build option and is uptodate for the recent xulrunner 1.9 upstream changes

Comment 5 Christian Persch 2007-12-10 17:34:19 UTC

+		  #if !defined(MOZ_STORAGE)

I don't see what that has to do with the configure check for debug builds?

+    char xpcomLocation[4096];

PATH_MAX.

I have to say I don't like the conditional compiling here on XPCOM_GLUE... we should simply remove support for non-xulrunner geckos, and possibly also for non-1.9 geckos.

Comment 6 Kjartan Maraas 2008-01-10 21:10:25 UTC

Yeah, leavint cruft for older development releases of gecko is probably not a good idea. Is there a newer patch somewhere or is this the latest?

Comment 7 Alexander Sack 2008-01-11 15:49:01 UTC

there are still patches landing that will change the way we need to fix the build-system. stay tuned; I will update the patch once this is sorted out.

Comment 8 Don Scorgie 2008-01-13 16:28:25 UTC

*** Bug 484991 has been marked as a duplicate of this bug. ***

Comment 9 Kjartan Maraas 2008-02-13 00:00:53 UTC

The last patch here doesn't work for me with the latest xulrunner from fedora rawhide at least...

checking which gecko to use... --exist: unknown option
--exist: unknown option
--exist: unknown option
--exist: unknown option
--exist: unknown option
--exist: unknown option

configure: error: No gecko found; you may need to adjust PKG_CONFIG_PATH or install a mozilla/firefox/xulrunner -devel package

Comment 10 Matthias Clasen 2008-02-13 00:55:40 UTC

Thats just a typo. Change the --exist to --exists

Comment 11 Willie Walker 2008-03-18 18:33:20 UTC

Hi All:

I'm curious about the progress of this.  I've heard rumor that Yelp may go down the route of migrating to the inaccessible WebKit.  If at all possible, if you can come up with an interim solution that provides a migration to the accessible Gecko 1.9 engine, a large community of people with disabilities will be very appreciative.

Will

Comment 12 Don Scorgie 2008-03-18 19:35:55 UTC

I'm planning on porting to gecko 1.9 in the upcoming release cycle (or at least, hoping yelp gets ported this release cycle).

There is an initial port to use WebKit, but it's very much just an experiment at this point.  Even if we were to integrate support, it would be an optional backend, along with gecko.  While WebKit is inaccessible, gecko will be the default and people would have to jump through hoops to enable WebKit support.

Note, since the pain we went through on the previous "gecko is inaccessible" bug (bug #157941), accessibility is one of my highest priorities.

Comment 13 Christian Persch 2008-04-02 18:01:13 UTC

Created attachment 108482 [details] [review]
updated patch, builds with xr1.9 and ff2.0/xr1.8

Comment 14 alp 2008-04-03 01:01:18 UTC

Willie,

We'd like to add AT-SPI support to WebKit in the GNOME 2.24 timeline and work is now in progress to add document accessibility to WebCore (the underlying engine) as a prerequisite.

The most recent patch for cross-platform accessibility support was landed a couple of days ago:

http://trac.webkit.org/projects/webkit/changeset/31517

It's important that applications intending to switch for 2.24 do so as early as possible in this cycle so we can get things fully featured and rock solid by then.

Since WebKit is a library, not a complete browser, we rely on feedback from developers and end users of GNOME applications like Epiphany (which announced the switch to WebKit a few days ago), and, I'm guessing Yelp.

Comment 15 Willie Walker 2008-04-07 18:36:14 UTC

Thanks!  I kindly request, however, that yelp migrate to the currently accessible Gecko in Firefox 3.0 and that the WebKit stuff be optional as described in comment #12.  This is not meant to go against WebKit, it's just that we know we have an accessible solution in Gecko, and we're all pretty tuckered out from the herculean task it took to get us there.

So, if http://bugzilla.gnome.org/attachment.cgi?id=108482 were something someone could approve and check in, it would be great and we could definitely test that.

Comment 16 Don Scorgie 2008-04-07 18:56:55 UTC

Willie: We haven't branched yet (will do so soon).  Then, as long as the chpe is happy [1] (and I can compile), the patch will go in.

Alp: We're tracking Webkit work in bug #512827 (although, as with everything else, I haven't had any time to spare on it).

As previously stated, yelp will continue supporting gecko as the default rendering engine.  If WebKit support lands in yelp (something I am aiming for), it will be an optional configure check.  If and when WebKit gains a11y on a par with gecko, we can begin discussing defaults then.

[1] I hope so as he proposed the patch

Comment 17 Kjartan Maraas 2008-04-19 16:24:56 UTC

This makes configure pass in my jhbuild setup but fails to build with this error:

make[3]: Entering directory `/home/kmaraas/cvs/gnome/yelp/src'
g++ -DHAVE_CONFIG_H -I. -I..  -I.. -I../src -DG_LOG_DOMAIN=\"Yelp\" -DPREFIX=\""/opt/gnome2"\" -DSYSCONFDIR=\""/opt/gnome2/etc"\" -DDATADIR=\""/opt/gnome2/share"\" -DLIBDIR=\""/opt/gnome2/lib"\" -DIMAGEDIR=\""/opt/gnome2/share/images/yelp"\" -DSERVERDIR=\"/opt/gnome2/libexec\" -DBINDIR=\""/opt/gnome2/bin"\" -DSHAREDIR=\""/opt/gnome2/share/yelp"\" -DMOZILLA_HOME=\""\"" -DGDU_ICON_PATH=\"/opt/gnome2/share/gnome-doc-utils/icons\"  -DXPCOM_GLUE -fshort-wchar -I/usr/include/xulrunner-sdk-1.9pre/stable   -DXPCOM_GLUE -fshort-wchar -I/usr/include/xulrunner-sdk-1.9pre/stable   -DXPCOM_GLUE -fshort-wchar -I/usr/include/xulrunner-sdk-1.9pre/unstable   -I/usr/include/xulrunner-sdk-1.9pre/unstable/. -I/usr/include/xulrunner-sdk-1.9pre/unstable/commandhandler -I/usr/include/xulrunner-sdk-1.9pre/unstable/content -I/usr/include/xulrunner-sdk-1.9pre/unstable/docshell -I/usr/include/xulrunner-sdk-1.9pre/unstable/dom -I/usr/include/xulrunner-sdk-1.9pre/unstable/fastfind -I/usr/include/xulrunner-sdk-1.9pre/unstable/find -I/usr/include/xulrunner-sdk-1.9pre/unstable/gtkembedmoz -I/usr/include/xulrunner-sdk-1.9pre/unstable/gfx -I/usr/include/xulrunner-sdk-1.9pre/unstable/layout -I/usr/include/xulrunner-sdk-1.9pre/unstable/necko -I/usr/include/xulrunner-sdk-1.9pre/unstable/pref -I/usr/include/xulrunner-sdk-1.9pre/unstable/string -I/usr/include/xulrunner-sdk-1.9pre/unstable/uriloader -I/usr/include/xulrunner-sdk-1.9pre/unstable/webbrwsr -I/usr/include/xulrunner-sdk-1.9pre/unstable/webshell -I/usr/include/xulrunner-sdk-1.9pre/unstable/widget -g -O0 -pthread -DORBIT2=1 -I/opt/gnome2/include/gconf/2 -I/opt/gnome2/include/glib-2.0 -I/opt/gnome2/lib/glib-2.0/include -I/opt/gnome2/include/gtk-unix-print-2.0 -I/opt/gnome2/include/gtk-2.0 -I/opt/gnome2/include/atk-1.0 -I/opt/gnome2/lib/gtk-2.0/include -I/opt/gnome2/include/pango-1.0 -I/opt/gnome2/include/gnome-vfs-2.0 -I/opt/gnome2/lib/gnome-vfs-2.0/include -I/opt/gnome2/include/libglade-2.0 -I/opt/gnome2/include/libgnome-2.0 -I/opt/gnome2/include/libbonobo-2.0 -I/opt/gnome2/include/orbit-2.0 -I/opt/gnome2/include/bonobo-activation-2.0 -I/opt/gnome2/include/libgnomeui-2.0 -I/opt/gnome2/include/libbonoboui-2.0 -I/opt/gnome2/include/libgnomecanvas-2.0 -I/opt/gnome2/include/libart-2.0 -I/usr/include/cairo -I/usr/include/libxml2 -I/usr/include/startup-notification-1.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/rarian    -DXPCOM_GLUE -fshort-wchar -I/usr/include/xulrunner-sdk-1.9pre/stable   -DXPCOM_GLUE -fshort-wchar -I/usr/include/xulrunner-sdk-1.9pre/stable   -DXPCOM_GLUE -fshort-wchar -I/usr/include/xulrunner-sdk-1.9pre/unstable   -fno-rtti  -fshort-wchar -g -O2 -Wall -Wno-unused  -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -g -O2 -MT yelp-Yelper.o -MD -MP -MF .deps/yelp-Yelper.Tpo -c -o yelp-Yelper.o `test -f 'Yelper.cpp' || echo './'`Yelper.cpp
In file included from /usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:42,
                 from /usr/include/xulrunner-sdk-1.9pre/stable/nsStringAPI.h:52,
                 from Yelper.cpp:28:
/usr/include/xulrunner-sdk-1.9pre/stable/nscore.h:51:21: error: prtypes.h: Ingen slik fil eller filkatalog
In file included from Yelper.cpp:28:
/usr/include/xulrunner-sdk-1.9pre/stable/nsStringAPI.h:54:19: error: prlog.h: Ingen slik fil eller filkatalog
In file included from Yelper.cpp:30:
/usr/include/xulrunner-sdk-1.9pre/unstable/gtkmozembed.h:57:1: warning: "NS_HIDDEN" redefined
In file included from /usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:42,
                 from /usr/include/xulrunner-sdk-1.9pre/stable/nsStringAPI.h:52,
                 from Yelper.cpp:28:
/usr/include/xulrunner-sdk-1.9pre/stable/nscore.h:117:1: warning: this is the location of the previous definition
In file included from Yelper.cpp:30:
/usr/include/xulrunner-sdk-1.9pre/unstable/gtkmozembed.h:63:1: warning: "NS_EXPORT_" redefined
In file included from /usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:42,
                 from /usr/include/xulrunner-sdk-1.9pre/stable/nsStringAPI.h:52,
                 from Yelper.cpp:28:
/usr/include/xulrunner-sdk-1.9pre/stable/nscore.h:208:1: warning: this is the location of the previous definition
In file included from Yelper.cpp:30:
/usr/include/xulrunner-sdk-1.9pre/unstable/gtkmozembed.h:64:1: warning: "NS_IMPORT_" redefined
In file included from /usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:42,
                 from /usr/include/xulrunner-sdk-1.9pre/stable/nsStringAPI.h:52,
                 from Yelper.cpp:28:
/usr/include/xulrunner-sdk-1.9pre/stable/nscore.h:206:1: warning: this is the location of the previous definition
In file included from /usr/include/xulrunner-sdk-1.9pre/unstable/nsISupports.h:10,
                 from /usr/include/xulrunner-sdk-1.9pre/unstable/nsIWebBrowser.h:10,
                 from /usr/include/xulrunner-sdk-1.9pre/unstable/gtkmozembed_internal.h:41,
                 from Yelper.cpp:31:
/usr/include/xulrunner-sdk-1.9pre/unstable/nsrootidl.h:12:20: error: prtime.h: Ingen slik fil eller filkatalog
In file included from /usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:42,
                 from /usr/include/xulrunner-sdk-1.9pre/stable/nsStringAPI.h:52,
                 from Yelper.cpp:28:
/usr/include/xulrunner-sdk-1.9pre/stable/nscore.h:347: error: ‘PRUint32’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nscore.h:360: error: ‘PRUint32’ does not name a type
In file included from /usr/include/xulrunner-sdk-1.9pre/stable/nscore.h:368,
                 from /usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:42,
                 from /usr/include/xulrunner-sdk-1.9pre/stable/nsStringAPI.h:52,
                 from Yelper.cpp:28:
/usr/include/xulrunner-sdk-1.9pre/stable/nsError.h:314: error: ‘nsresult’ does not name a type
In file included from /usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:42,
                 from /usr/include/xulrunner-sdk-1.9pre/stable/nsStringAPI.h:52,
                 from Yelper.cpp:28:
/usr/include/xulrunner-sdk-1.9pre/stable/nscore.h:424: error: ‘PRUint16’ does not name a type
In file included from /usr/include/xulrunner-sdk-1.9pre/stable/nsStringAPI.h:52,
                 from Yelper.cpp:28:
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:158: error: ‘PRUint32’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:194: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:218: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:254: error: ‘PRUint32’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:288: error: ‘PRUint32’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:304: error: expected constructor, destructor, or type conversion before ‘*’ token
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:327: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:360: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:382: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:402: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:427: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:445: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:458: error: expected ‘,’ or ‘...’ before ‘aIsVoid’
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:458: error: ISO C++ forbids declaration of ‘PRBool’ with no type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:466: error: ‘PRBool’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:517: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:541: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:577: error: ‘PRUint32’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:611: error: ‘PRUint32’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:650: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:683: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:705: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:725: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:750: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:768: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:781: error: expected ‘,’ or ‘...’ before ‘aIsVoid’
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:781: error: ISO C++ forbids declaration of ‘PRBool’ with no type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:789: error: ‘PRBool’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:828: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOMStrings.h:847: error: ‘nsresult’ does not name a type
In file included from /usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:44,
                 from /usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsImpl.h:46,
                 from /usr/include/xulrunner-sdk-1.9pre/stable/nsStringAPI.h:53,
                 from Yelper.cpp:28:
/usr/include/xulrunner-sdk-1.9pre/stable/nsID.h:60: error: ‘PRUint32’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsID.h:61: error: ‘PRUint16’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsID.h:62: error: ‘PRUint16’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsID.h:63: error: ‘PRUint8’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsID.h:76: error: ‘PRBool’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsID.h:95: error: ‘PRBool’ does not name a type
In file included from /usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsImpl.h:46,
                 from /usr/include/xulrunner-sdk-1.9pre/stable/nsStringAPI.h:53,
                 from Yelper.cpp:28:
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:86: error: ISO C++ forbids declaration of ‘nsresult’ with no type
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:86: error: ‘nsresult’ declared as a ‘virtual’ field
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:86: warning: ‘visibility’ attribute ignored
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:86: warning: ‘regparm’ attribute only applies to function types
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:86: warning: ‘cdecl’ attribute only applies to function types
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:86: error: expected ‘;’ before ‘QueryInterface’
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:94: error: ISO C++ forbids declaration of ‘nsrefcnt’ with no type
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:94: error: ‘nsrefcnt’ declared as a ‘virtual’ field
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:94: warning: ‘visibility’ attribute ignored
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:94: warning: ‘regparm’ attribute only applies to function types
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:94: warning: ‘cdecl’ attribute only applies to function types
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:94: error: expected ‘;’ before ‘AddRef’
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:103: error: ISO C++ forbids declaration of ‘nsrefcnt’ with no type
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:103: error: ‘nsrefcnt’ declared as a ‘virtual’ field
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:103: warning: ‘visibility’ attribute ignored
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:103: warning: ‘regparm’ attribute only applies to function types
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:103: warning: ‘cdecl’ attribute only applies to function types
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:103: error: expected ‘;’ before ‘Release’
In file included from /usr/include/xulrunner-sdk-1.9pre/stable/nsDebug.h:49,
                 from /usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsUtils.h:57,
                 from /usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsImpl.h:50,
                 from /usr/include/xulrunner-sdk-1.9pre/stable/nsStringAPI.h:53,
                 from Yelper.cpp:28:
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:101: error: ISO C++ forbids declaration of ‘nsresult’ with no type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:101: error: typedef ‘nsresult’ is initialized (use __typeof__ instead)
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:101: error: ‘PR_CALLBACK’ was not declared in this scope
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:101: error: ‘nsGetModuleProc’ was not declared in this scope
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:139: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:153: error: ‘nsGetModuleProc’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:196: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:216: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:230: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:243: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:256: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:269: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:297: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:302: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:320: warning: ‘NS_Alloc’ initialized and declared ‘extern’
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:320: error: ‘PRSize’ was not declared in this scope
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:341: error: ‘PRSize’ has not been declared
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:383: warning: ‘NS_DebugBreak’ initialized and declared ‘extern’
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:383: error: variable or field ‘NS_DebugBreak’ declared void
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:383: error: ‘PRUint32’ was not declared in this scope
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:384: error: expected primary-expression before ‘const’
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:384: error: expected primary-expression before ‘const’
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:385: error: expected primary-expression before ‘const’
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:385: error: ‘PRInt32’ was not declared in this scope
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:420: error: ‘PRUint32’ has not been declared
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:423: error: ‘PRUint32’ has not been declared
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:436: error: ‘nsrefcnt’ has not been declared
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:437: error: ‘PRUint32’ has not been declared
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:440: error: ‘nsrefcnt’ has not been declared
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:463: error: ‘PRBool’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:466: error: ‘PRBool’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:550: error: ‘nsresult’ does not name a type
/usr/include/xulrunner-sdk-1.9pre/stable/nsXPCOM.h:553: error: ‘nsresult’ does not name a type
In file included from /usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsUtils.h:57,
                 from /usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsImpl.h:50,
                 from /usr/include/xulrunner-sdk-1.9pre/stable/nsStringAPI.h:53,
                 from Yelper.cpp:28:
/usr/include/xulrunner-sdk-1.9pre/stable/nsDebug.h:275: error: expected constructor, destructor, or type conversion before ‘void’
In file included from /usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsImpl.h:50,
                 from /usr/include/xulrunner-sdk-1.9pre/stable/nsStringAPI.h:53,
                 from Yelper.cpp:28:
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsUtils.h:102: error: expected constructor, destructor, or type conversion before ‘extern’
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h: In instantiation of ‘const nsIID nsISupports::COMTypeInfo<int>::kIID’:
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:69:   instantiated from here
/usr/include/xulrunner-sdk-1.9pre/stable/nsISupportsBase.h:69: error: too many initializers for ‘const nsIID’
make[3]: *** [yelp-Yelper.o] Error 1
make[3]: Leaving directory `/home/kmaraas/cvs/gnome/yelp/src'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/kmaraas/cvs/gnome/yelp/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/kmaraas/cvs/gnome/yelp'
make: *** [all] Error 2
*** error during stage build of yelp: ########## Error running make   *** [1/1]

Comment 18 Kjartan Maraas 2008-04-19 16:27:06 UTC

Forgot to mention that this is with F9 rawhide.

Comment 19 Christian Kirbach 2008-05-01 22:49:53 UTC

Patch works for me on Ubuntu 8.04 with xulrunner 1.9 from Firefox beta5
nice work

Comment 20 Willie Walker 2008-05-06 19:41:50 UTC

(In reply to comment #19)
> Patch works for me on Ubuntu 8.04 with xulrunner 1.9 from Firefox beta5
> nice work
> 

Just a query on where this stands.  Is it ready for us non-yelpians to test?

Comment 21 Don Scorgie 2008-05-23 17:17:19 UTC

Patch built correctly against XULRunner and FF2 for me, so I've committed it to SVN trunk.

If this causes any problems or issues, please raise a new bug (or comment further in this one).

Thanks.

2008-05-23  Don Scorgie  <dscorgie@svn.gnome.org>

	* configure.in:
	* m4/gecko.m4:
	* src/Makefile.am:
	* src/yelp-gecko-services.cpp:
	* src/yelp-gecko-utils.cpp:
	* src/yelp-io-channel.c:
	* src/yelp-main.c (main):
	Add support for XULRunner / Firefox 3 backend
	Bug # 499744 - Patch from Christian Persch

Comment 22 Hammer Attila 2008-07-14 07:49:41 UTC

Dear Developers!

dscorgie@svn.gnome.org> wroted:
 
"        * configure.in:
        * m4/gecko.m4:
        * src/Makefile.am:
        * src/yelp-gecko-services.cpp:
        * src/yelp-gecko-utils.cpp:
        * src/yelp-io-channel.c:
        * src/yelp-main.c (main):
        Add support for XULRunner / Firefox 3 backend
        
Bug # 499744
 - Patch from Christian Persch"   

How can I test or use this backend with yelp? This mean yelp will be accessible with GNOME 2.24?

Thanks,

Attila