After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 499692 - [0.11][audioresample] Don't do audioconverts job
[0.11][audioresample] Don't do audioconverts job
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-11-26 08:10 UTC by Sebastian Dröge (slomo)
Modified: 2008-10-30 13:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Sebastian Dröge (slomo) 2007-11-26 08:10:53 UTC
Hi,
currently audioresample converts all input it gets to doubles, does the resampling and then converts them back to the original format (see resample_ref.c:159 and following for example). As this is audioconverts job it would probably be better to let audioresample just support what it can handle internally and let audioconvert do everything else.

This would require changing the pad templates so should be postponed until 0.11 :)
Comment 1 Sebastian Dröge (slomo) 2008-10-30 13:47:55 UTC
Actually, after thinking about it again, this is a good idea as audioresample knows the real input format while a audioconvert after audioresample wouldn't.

If audioresample wouldn't convert internally audioconvert would add dithering/noise shaping to the output of audioresample although this is not really needed.