After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 499242 - [patch] workaround the broken tags encoding for mp3 files
[patch] workaround the broken tags encoding for mp3 files
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.16
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-11-23 20:03 UTC by Shixin Zeng
Modified: 2009-08-09 10:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch against gst-plugins-good-0.10.6 (2.48 KB, patch)
2007-11-23 20:08 UTC, Shixin Zeng 		committed Details | Review

Description Shixin Zeng 2007-11-23 20:03:17 UTC 
some idv2 tags of mp3 files are actually in local encoding, in spite that they are declared to be "iso-8859-1", because of the ignorance of encoding, I think. These files work fine on windows (I guess it's because windows doesn't convert the encoding before showing these tags?)

Here's the patch to work around this problem, for tags declared in "ISO-8859-1", try to use the value specified by the environment variable "GST_ID3V1_TAG_ENCODING", "GST_ID3_TAG_ENCODING" or "GST_TAG_ENCODING" to convert the strings to 'UTF-8'; if it fails, then try to use local charset, and finally fallback to 'ISO-8859-1'.
Comment 1 Shixin Zeng 2007-11-23 20:08:44 UTC 
Created attachment 99556 [details] [review]
patch against gst-plugins-good-0.10.6

I'm not the author of this patch. The patch is from http://www.gnome-cn.org/resources/blog/lonestar/gstreamer-0-10-mp3-id3tag-luanmawentidejiejue(in Simplified Chinese)
Comment 2 Sebastian Dröge (slomo) 2009-08-09 10:54:19 UTC 
commit 494555cecd707225977773799626e6cc2cb2ff88
Author: LoneStar <lone@auvtech.com>
Date:   Sun Aug 9 12:52:17 2009 +0200

    id3demux: Try GST_*_TAG_ENCODING and locale encoding if tags are not UTF8
    
    Fixes bug #499242.