After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 499239 - gstrtpmp4adepay
gstrtpmp4adepay
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-11-23 19:59 UTC by Jayarama S. Santana
Modified: 2007-11-27 11:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to solve the problem (5.34 KB, patch)
2007-11-23 19:59 UTC, Jayarama S. Santana 		committed Details | Review
Patch (635 bytes, patch)
2007-11-26 21:12 UTC, Jayarama S. Santana 		committed Details | Review

Description Jayarama S. Santana 2007-11-23 19:59:00 UTC 
When more than a frame is multiplexed inside an audio packet, the plugin doesn't work properly.
Comment 1 Jayarama S. Santana 2007-11-23 19:59:48 UTC 
Created attachment 99554 [details] [review]
Patch to solve the problem
Comment 2 Wim Taymans 2007-11-26 19:17:51 UTC 
I changed it a little bit so that it is smaller and does better bounds checking. Please retest as I could not find an example stream (tested with subframe == 0).


        Based on Path by: Jayarama S. Santana <sundarsantana at gmail dot com>

        * gst/rtp/gstrtpmp4adepay.c: (gst_rtp_mp4a_depay_setcaps),
        (gst_rtp_mp4a_depay_process):
        * gst/rtp/gstrtpmp4adepay.h:
        Fix depayloading when multiple frames are inside one RTP packet.
        Fixes #499239.
Comment 3 Jayarama S. Santana 2007-11-26 21:12:50 UTC 
Created attachment 99684 [details] [review]
Patch

Patch
Comment 4 Jayarama S. Santana 2007-11-26 21:14:02 UTC 
There is a small mistake (one changed inequality) which is preventing the audio from being decoded when more than one frame is multiplexed. I'm attaching a patch with the correction.
Comment 5 Wim Taymans 2007-11-27 11:11:18 UTC 
        Patch by: Jayarama S. Santana <sundarsantana at gmail dot com>

        * gst/rtp/gstrtpmp4adepay.c: (gst_rtp_mp4a_depay_process):
        Fix wrong comparison in overrun check. Fixes #499239 some more.