After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 499052 - Filter removal on xfade backend is not robust.
Filter removal on xfade backend is not robust.
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: playback
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-11-22 21:47 UTC by Christophe Dehais
Modified: 2009-11-08 12:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Christophe Dehais 2007-11-22 21:47:33 UTC 
Removal of filters on the xfade backends is not robust (using trunk) in several ways:
* removal while playing a song will stop playback, refuse to play anything anymore and finally hang RB a while after if insisting with the UI.
* removal while playback is paused will hang when removing the last filter.

I used the python console with something like this:
import gst
a = gst.element_factory_make ("volume")
shell.props.shell_player.props.player.add_filter(a)
b = gst.element_factory_make ("audioinvert")
shell.props.shell_player.props.player.add_filter(b)

Insertion works both while playing and when paused (except for ladspa filters, see #499051)
Comment 1 Christophe Dehais 2007-11-22 22:00:48 UTC 
(In reply to comment #0)
> * removal while playback is paused will hang when removing the last filter.

Well, I was even too nice with it, because it seems to crash even on other filters of the chain.

> Insertion works both while playing and when paused (except for ladspa filters,
>see #499051)
I meant Bug 499051.
Comment 2 Jonathan Matthew 2009-11-08 12:12:09 UTC 
fixed in commit 8b3120d4e81031c3e2bf8e1e7d1eb2cd1e36c38c

as far as I can tell, filter insertion and removal now works properly with crossfading.