Created attachment 99498 [details] [review]
xulrunner patch

Thanks, committed.

(I tested quickly with gecko 1.8 and it worked, if it breaks older versions we could just bump the requirement imo.)

Does not work any more with xulrunner 1.9b5

Created attachment 110253 [details] [review]
fix build against xulrunner 1.9b5

work in progress. configure succeeds but build fails. advice welcome

/bin/bash ../libtool --tag=CC   --mode=link gcc -Wall -Wunused -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare -Werror -pthread -DORBIT2=1 -I/opt/gnome2/include/glib-2.0 -I/opt/gnome2/lib/glib-2.0/include -I/opt/gnome2/include/gtk-2.0 -I/opt/gnome2/lib/gtk-2.0/include -I/opt/gnome2/include/atk-1.0 -I/opt/gnome2/include/cairo -I/opt/gnome2/include/pango-1.0 -I/opt/gnome2/include -I/opt/gnome2/include/pixman-1 -I/opt/gnome2/include/libglade-2.0 -I/opt/gnome2/include/libxml2 -I/opt/gnome2/include/gconf/2 -I/opt/gnome2/include/orbit-2.0 -I/opt/gnome2/include/libwnck-1.0 -I/opt/gnome2/include/startup-notification-1.0 -I/usr/include/freetype2 -I/usr/include/libpng12   -DXPCOM_GLUE -fshort-wchar -I/usr/include/xulrunner-1.9b5/stable -I/usr/include/nspr   -DXPCOM_GLUE -fshort-wchar -I/usr/include/xulrunner-1.9b5/unstable -I/usr/include/nspr    -g -O1 -Wall -march=pentium-m -R   -o libdevhelp-1.la -rpath /opt/gnome2/lib libdevhelp_1_la-bacon-message-connection.lo libdevhelp_1_la-dh-marshal-main.lo libdevhelp_1_la-dh-base.lo libdevhelp_1_la-dh-book-tree.lo libdevhelp_1_la-dh-error.lo libdevhelp_1_la-dh-html.lo libdevhelp_1_la-dh-keyword-model.lo libdevhelp_1_la-dh-link.lo libdevhelp_1_la-dh-search.lo libdevhelp_1_la-dh-parser.lo libdevhelp_1_la-dh-preferences.lo libdevhelp_1_la-dh-util.lo libdevhelp_1_la-dh-window.lo libdevhelp_1_la-eggfindbar.lo libcppwrapper.la -pthread -L/opt/gnome2/lib -lgthread-2.0 -lrt -lglade-2.0 -lxml2 -lgconf-2 -lwnck-1 -lgtk-x11-2.0 -lgdk-x11-2.0 -latk-1.0 -lgio-2.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lpango-1.0 -lcairo -lgobject-2.0 -lgmodule-2.0 -ldl -lglib-2.0   -L/usr/lib/xulrunner-devel-1.9b5/lib -lxpcomglue    
libtool: link: only absolute run-paths are allowed
make[3]: *** [libdevhelp-1.la] Fehler 1

shamelessly ripped m4/gecko.m4 and ideas from yelp trunk

Created attachment 110798 [details] [review]
Current working patch

Here is the patch we use in Debian.
 - The m4 stuff based on Christian's work.
 - Makefile.am is modified to remove the -R flag unless appropriate.
 - The separation between libcppwrapper.la and libdevhelp-1.la is dropped; the flags should still be different thanks to CXXFLAGS, and with this separation libtool gets confused and forgets to link with g++ instead of gcc. (It works with gecko 1.8 because dynamic linking brings libstdc++ through libxul.so.)
 - dh_gecko_utils_init is patched to use libxpcomglue (patch from Ubuntu).
 - The color pref in default-prefs-gecko-1-9.js is changed to get the colors correctly.

Thanks. You say it's a "current working patch", does that mean it's work in progress? I have no idea about the black magic that is gecko builds, but feel free to commit to the gnome-2-22 branch (svn.gnome.org/svn/devhelp/branches/gnome-2-22) if you think that's the right thing to do.

I mean that this is the patch we apply to produce a working version of devhelp using xulrunner 1.9 beta5.

However it looks like the patch breaks the build against xulrunner 1.8. I’ll fix that first before committing.

Created attachment 111599 [details] [review]
Patch working for gecko 1.8 and 1.9

Here is the fixed version that builds against both gecko 1.8 and 1.9.

As requested, this is now committed (r1012) to the 2.22 branch.

Closing then, thanks.