GNOME Bugzilla – Bug 498277
Cannot set XDMCP MaxSessions
Last modified: 2007-11-26 23:38:13 UTC
After upgrading Fedora Core 6 to Fedora 8 with gdm-2.20.1-7.fc8, I cannot define XDMCP MaxSessions. Many stations login just fine, but I can't change the default value for MaxSessions from 16. Nov 19 08:31:24 lucy gdm-binary[14678]: DEBUG: gdm_xdmcp_handle_request: xdmcp_pending=0, MaxPending=4, xdmcp_sessions=17, MaxSessions=16, ManufacturerID= Nov 19 08:31:24 lucy gdm-binary[14678]: WARNING: Maximum number of open XDMCP sessions reached My configuration: [xdmcp] Enable=true MaxSessions=2000 DisplaysPerHost=100 It's strange that some or all other configuration keys are not affected. FWIW, I tried rebooting, "init 3; init 5", gdm-restart, and editing the defaults file. I believe this bug is /not/ the same as bug 478441. Andrew
Hi, Did you used gdm.conf or gdm.conf-custom? Can you try to use each other to see of there is a difference? Have a nice day, Francis
Looking at the code, it appears that when Jon McCann cleaned up the xdmcp code, the defaults are now all hardcoded in daemon/gdm-xdmcp-manager.c. There are properties which allow you to set the values to different ones, but there doesn't appear to be any code to plug this in to the GDM configuration file. I'd appreciate it if someone could provide a patch to fix this regression.
Created attachment 99441 [details] [review] hasty patch This should fix two settings, but it doesn't yet fix them all.
Could you add the rest? I'd love to get this patch upstream before the next 2.20 release.
Created attachment 99461 [details] [review] a more thorough patch against GDM 2.20.1 I left out a few XDMCP keys (below**) that didn't have variable definitions in manager->priv. ** GDM_KEY_PING_INTERVAL, GDM_KEY_WILLING, GDM_KEY_XDMCP_PROXY, GDM_KEY_XDMCP_PROXY_XSERVER, GDM_KEY_XDMCP_PROXY_RECONNECT, GDM_KEY_XDMCP_PROXY_XSERVER GDM_KEY_WILLING, GDM_KEY_XDMCP_PROXY, and GDM_KEY_XDMCP_PROXY_XSERVER are defined but never used anywhere. That's seems like 2 bugs, and it's beyond the scope of a config bug patch. Perhaps 2 new bugs should be filed to implement the 2 features. (These keys are documented in the GDM docs.) GDM_KEY_PING_INTERVAL and GDM_KEY_XDMCP_PROXY_RECONNECT are used outside of manager->priv and may be OK. When is the next GDM 2.20.x release?
WILLING corresponds to the "willing_script" in the code. Looking at the 2.18 code, the PROXY stuff is disabled and unused. So, I think we just need to fix WILLING and we can consider this fixed for 2.20. Sound good? If you can fix thie WILLING issue then I think we will have things working as well as they did in 2.18. Could you provide an updated patch? I believe PING_INTTERVAL is okay. As I said, I don't think the GDM_KEY_XDMCP_PROXY_RECONNECT is really used sicne GDM_KEY_XDMCP_PROXY is disabled.
Created attachment 99546 [details] [review] also fixes the willing script (patch against GDM 2.20.1) Please mark bug confirmed.
Thanks so much. Looks good. Applied to 2.20 branch.