After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 498095 - Duplicate mnemonics
Duplicate mnemonics
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.28.x (obsolete)
Other Linux
: Normal minor
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
aklapper[mnemonics] ghop[2007-14]
Depends on:
Blocks: 324810
 
 
Reported: 2007-11-19 06:32 UTC by Akhil Laddha
Modified: 2009-10-13 09:37 UTC
See Also:
GNOME target: ---
GNOME version: 2.27/2.28


Attachments
https://bugzilla.novell.com/show_bug.cgi?id=8886 (1.59 KB, patch)
2007-12-02 17:46 UTC, David Turner
committed Details | Review
https://bugzilla.novell.com/show_bug.cgi?id=8805 (1013 bytes, patch)
2007-12-02 17:49 UTC, David Turner
needs-work Details | Review
screenshot (23.59 KB, image/png)
2008-01-22 09:42 UTC, Suman Manjunath
  Details
Fix mnemonic clash in new appointment, new task (2.16 KB, patch)
2008-08-11 16:09 UTC, Dima
committed Details | Review

Description Akhil Laddha 2007-11-19 06:32:52 UTC
https://bugzilla.novell.com/show_bug.cgi?id=8805

Steps to reproduce the problem:
1. Click Calendar.
2. Right click Personal in the Lefthand taskpane. 
3. Click Properties

Duplicate Hotkey "O"
Comment 1 Akhil Laddha 2007-11-19 06:38:46 UTC
https://bugzilla.novell.com/show_bug.cgi?id=8886

Triplicate Hotkey "C" in Contact Editor window.

Steps to reproduce the problem:
1. Click Programs->Novell Evolution.
2. Click Contacts
3. Click New
Comment 2 Akhil Laddha 2007-11-19 06:50:50 UTC
https://bugzilla.novell.com/show_bug.cgi?id=8782

Duplicate hotkey in New VFolder dialog for all Add and Remove options.
Comment 3 Akhil Laddha 2007-11-19 07:44:44 UTC
https://bugzilla.novell.com/show_bug.cgi?id=8780

Duplicate hotkey R in Advanced Search dialogue 

1.Search > Advanced Search 
2.Click Add button.
Triple or more hotkey R for Remove button
Comment 4 Akhil Laddha 2007-11-19 07:50:45 UTC
https://bugzilla.novell.com/show_bug.cgi?id=8844

Steps to reproduce the problem:
1. Right click on message 
2. Select Mark for follow up 

Duplicate Hotkey "C" found
Comment 5 Akhil Laddha 2007-11-19 07:54:23 UTC
https://bugzilla.novell.com/show_bug.cgi?id=8808

Duplicate Hotkey "C" found in Edit Categories window when creating a new 
task.

Steps to reproduce the problem:
1. Click Tasks.
2. Click New Task
3. Click Categories.
Comment 6 Akhil Laddha 2007-11-19 07:58:43 UTC
https://bugzilla.novell.com/show_bug.cgi?id=8783

hotkey Alt s does not function on Add Alarm dialogue

1. Select New and All Day Appoinment
2. Click on Alarm select Customize option
3. Click on the Add button
4. Enable the checkbox for Custom Message
Comment 7 Akhil Laddha 2007-11-19 08:01:52 UTC
https://bugzilla.novell.com/show_bug.cgi?id=8851

Duplicate Hotkeys "R" and "A" found when creating a search folder

1. Menu bar > Edit > Search folder 
2. Click Add
Comment 8 Akhil Laddha 2007-11-19 12:43:03 UTC
https://bugzilla.novell.com/show_bug.cgi?id=8729

1. Menu bar > New > Contact List 
W - Where hotkey does not function.
Comment 9 Akhil Laddha 2007-11-19 13:23:20 UTC
https://bugzilla.novell.com/show_bug.cgi?id=8825

Steps to reproduce the problem:
1. Menu bar > New > Mail Folder

There is no hotkey present for Create

Comment 10 David Turner 2007-12-02 17:46:54 UTC
Created attachment 100053 [details] [review]
https://bugzilla.novell.com/show_bug.cgi?id=8886

Patch to fix https://bugzilla.novell.com/show_bug.cgi?id=8886 (The triple C mnemonic clash)
Comment 11 David Turner 2007-12-02 17:49:32 UTC
Created attachment 100054 [details] [review]
https://bugzilla.novell.com/show_bug.cgi?id=8805

Patch for https://bugzilla.novell.com/show_bug.cgi?id=8805
(The o mnemonic clash)

(N.B. this isn't the patch I mentioned on the GHOP issue 14, the other one is)
Comment 12 Milan Crha 2007-12-03 17:42:51 UTC
You know, bug reference in ChangeLog. The first is fine, can commit to trunk. The second, it's not so easy, different calendar types has different options. For example, On The Web calendar has option "_Refresh".
BTW, are you going to produce patch for all issues in this bug? If yes, it will be better to have one patch for all of them in one, not couple of small partial patches for one bug. Thanks.
Comment 13 Suman Manjunath 2008-01-14 08:24:06 UTC
Committed to SVN trunk as r34810
(http://svn.gnome.org/viewvc/evolution?view=revision&revision=34810)
Comment 14 Suman Manjunath 2008-01-22 09:42:05 UTC
Created attachment 103410 [details]
screenshot

see mnemonics for 'Edit' menu and 'Description' - also check if the same bug exists in task and memo editors. 
If it does, please fix it. Else, make the hotkeys uniform.
Comment 15 Matthew Barnes 2008-03-11 00:36:48 UTC
Bumping version to a stable release.
Comment 16 Dima 2008-08-11 16:09:43 UTC
Created attachment 116360 [details] [review]
Fix mnemonic clash in new appointment, new task

Fixing mnemonics clashes with "_Edit", as well as making sure new mnemonics are consistent across dialogs and don't produce new clashes.
Comment 17 Milan Crha 2008-08-12 08:23:37 UTC
Looks good, I'll commit to trunk and announce a string change after a little test.
Comment 18 Milan Crha 2008-08-12 09:03:08 UTC
A little bit extended patch from comment #16 committed to trunk. Committed revision 35965.

The only thing I realized was the mnemonic_widget wasn't set for description label in memo-page, so I fixed this together with your changes. I hope it's fine.
By the way, thanks for the patch.
Comment 19 Matthew Barnes 2008-08-28 00:32:17 UTC
So what's left for this bug?  Can someone summarize?
Comment 20 Akhil Laddha 2009-10-13 05:40:14 UTC
Issues mentioned in comment 3, 4, 5, 6, 8 are still valid against 2.28.0
Comment 21 Milan Crha 2009-10-13 09:37:22 UTC
comment #3 - CantFix, it's better to have a duplicate hotkey than none; note
             the buttons are generated based on the conditions count; There is
             something similar in a contact search dialog (when you hit "To:"
             button in a composer), it have been left there intentionally for
             the same reason.

comment #4 - done in evo
comment #5 - done in eds
comment #6 - done in evo
comment #8 - done in evo

Created commit 5652aa2 in eds master (2.29.1+)
Created commit dc29530 in evo master (2.29.1+)