After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 497908 - gnome-power-manager-2.20.0 fails make check on desktop machine
gnome-power-manager-2.20.0 fails make check on desktop machine
Status: RESOLVED OBSOLETE
Product: gnome-power-manager
Classification: Deprecated
Component: general
2.20.x
Other All
: Normal minor
: ---
Assigned To: GNOME Power Manager Maintainer(s)
GNOME Power Manager Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-11-18 14:09 UTC by Hans de Graaff
Modified: 2009-03-04 21:58 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20



Description Hans de Graaff 2007-11-18 14:09:09 UTC
Please describe the problem:
gnome-power-manager-2.20.0 fails some of the checks in 'make check' on a desktop machine without a battery. For reference this bug got filed at Gentoo: https://bugs.gentoo.org/show_bug.cgi?id=196490

It also mentions someone who got failures with a battery on this test, but currently no details of that failure are included and I have not tested this yet on a machine with a battery.

Steps to reproduce:
0. grab a machine without a battery
1. ./configure
2. make check
3. FAIL


Actual results:
> check #73     GpmCellUnit:    make sure broken battery isn't charged......OK [not charged]
> check #74     GpmCellUnit:    get missing icon......OK [icon correct]
> check #75     GpmCellUnit:    get middle icon......OK [icon correct]
> check #76     GpmCellUnit:    get charged icon......OK [icon correct]
> check #77     GpmCellUnit:    setting measure......OK [measure correct]
FAILED [did not find battery device]
FAIL: gnome-power-self-test

Expected results:
I would expect all checks that can be passed on this machine to pass, and all tests that can't be checked due to lack of hardware to be skipped (possibly with a warning).

Does this happen every time?
Yes.

Other information:
I've tried to fix this in gpm_st_cell by skipping the remainder of the tests when udi == NULL. This seems to work but does not produce nice output, so I guess this is not the right approach here. However, then I get this failure:

> check #78     GpmCellArray:   make sure we get a non null cell array......OK [got GpmCellArray]
> check #79     GpmCellArray:   make sure we get set type......OK [set type]
> check #80     GpmCellArray:   make sure we got a single recall notice...FAILED [did not get recall (install fdi?)]
FAIL: gnome-power-self-test
Comment 1 Richard Hughes 2007-11-18 15:47:40 UTC
Can you try with trunk please:

2007-11-18  Richard Hughes  <richard@hughsie.com>

	* src/gpm-cell-array.c: (gpm_st_cell_array):
	* src/gpm-cell.c: (gpm_st_cell):
	* src/gpm-self-test.c: (gpm_st_warning):
	* src/gpm-self-test.h:
	Try to pass make distcheck on a desktop machine.
Comment 2 Peter Hjalmarsson 2008-03-05 11:38:58 UTC
Is this supposed to be fixed in gnome-power-manager-2.21.92?
make check still fails with that version.
Comment 3 Gilles Dartiguelongue 2008-03-29 23:58:18 UTC
Here is my output:

> check #78	GpmCell: 	make sure we get a non null cell...
** (gnome-power-self-test:14418): WARNING **: Cannot connect to session bus: Did not receive a reply. Possible causes include: the remote application did not send a reply, the message bus security policy blocked the reply, the reply timeout expired, or the network connection was broken.
...OK [got GpmCell]
> check #79	GpmCell: 	make sure we get a non null unit......OK [got GpmCellUnit]
> check #80	GpmCell: 	make sure we get a null description for nonassigned cell......OK [got description <b>Status:</b> Missing <b>Percentage charge:</b> 0%]
> check #81	GpmCell: 	can we assign device......OK [set type okay]
> check #82	GpmCell: 	make sure we got a single recall notice...FAILED [did not get recall (install fdi?)]
FAIL: gnome-power-self-test
===================
1 of 1 tests failed
===================

I have hal-0.5.10, with a somewhat old hal-info (20071030) but I think it shouldn't fail just because it can't find some hal info.
Comment 4 Richard Hughes 2009-03-04 14:52:28 UTC
Thanks for taking the time to report this bug.
However, you are using a version that is too old and not supported anymore. GNOME developers are no longer working on that version, so unfortunately there will not be any bug fixes for the version that you use.

By upgrading to a newer version of GNOME you could receive bug fixes and new functionality. You may need to upgrade your Linux distribution to obtain a newer version of GNOME.
Please feel free to reopen this bug if the problem still occurs with a newer version of GNOME.
Comment 5 Peter Hjalmarsson 2009-03-04 21:58:14 UTC
I can replicate this on 2.24.4.

So which versions are considered supported?