GNOME Bugzilla – Bug 497430
Doesn't play back normal files over DAAP in 0.11.3
Last modified: 2007-11-17 13:47:36 UTC
When try to playback files from a remote DAAP machine using 0.11.3, nothing is being played back. Adding some debug in rb-shell-player: Rhythmbox-Message: rb_shell_player_entry_activated_cb: Entry has playback URI Unknown (location: daap://192.168.1.106:3689/databases/1/items/4.mp3?session-id=136937119, mount: Unknown) You can see it's actually getting the streamURI as Unknown (huh?) instead of empty. Removing the use of ->get_playback_uri should "fix" the problem. I still have no idea why MOUNTPOINT would be Unknown instead of empty. handle_song_listing calls entry_set_string_prop() which only sets the value to Unknown when the value isn't UTF-8 or an empty string (streamURI is none-NULL in handle_song_listing). Weird. Reported from: https://bugzilla.redhat.com/show_bug.cgi?id=382351
Created attachment 99218 [details] [review] rb-0.11.3-fix-daap.patch Might fix it...
On line 1012 of rb-daap-share.c, we add an empty string if the client requested daap.songdataurl, which is where we get the empty string we see on the client side. The fix works for me. Maybe we could do some more checking, like making sure we get something that looks like a real URL, but I'm not sure there's much of a point.
2007-11-17 Bastien Nocera <hadess@hadess.net> * plugins/daap/rb-daap-connection.c: (handle_song_listing), (rb_daap_connection_state_done): Fix DAAP sharing in client mode not playing anything (Closes: #497430)