After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 497293 - gsttimeoverlay compile error in win32
gsttimeoverlay compile error in win32
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Windows
: Normal minor
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-11-16 05:38 UTC by Kwang Yul Seo
Modified: 2007-12-09 05:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make it compile in MSVC 6.0 (1.04 KB, patch)
2007-12-03 06:09 UTC, Kwang Yul Seo 		none Details | Review

Description Kwang Yul Seo 2007-11-16 05:38:04 UTC 
MSVC does not provide rint() function used by gsttimeoverlay, so the gsttimeoverlay won't compile using MSVC.
Comment 1 Kwang Yul Seo 2007-12-03 06:09:48 UTC 
Created attachment 100091 [details] [review]
Make it compile in MSVC 6.0

This patch fixes the compile errors in MSVC 6.0
 1) Provide rint() implementation.
 2) Use gst_util_guint64_to_gdouble for unsinged __int64 to double conversion.
Comment 2 Sebastian Dröge (slomo) 2007-12-09 05:02:11 UTC 
Thanks, this is fixed in CVS now with a slightly different fix.

2007-12-09  Sebastian Dröge  <slomo@circular-chaos.org>

	Based on a patch by: Kwang Yul Seo <kwangyul dot seo at gmail dot com>

	* configure.ac:
	* ext/cairo/gsttimeoverlay.c:
	  (gst_cairo_time_overlay_print_smpte_time):
	  Fix compilation with MSVC by using gst_util_guint64_to_gdouble()
	  and checking for rint() and implementing it ourself if it doesn't
	  exist.