After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 497017 - [PATCH] H.264 RTP depayloader leaks memory in setcaps
[PATCH] H.264 RTP depayloader leaks memory in setcaps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-11-15 11:12 UTC by Tommi Myöhänen
Modified: 2007-11-15 17:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch that fixes small memory leak in gstrtph264depay.c (600 bytes, patch)
2007-11-15 11:12 UTC, Tommi Myöhänen
committed Details | Review

Description Tommi Myöhänen 2007-11-15 11:12:08 UTC
==10975== 78 (36 direct, 42 indirect) bytes in 3 blocks are definitely lost in loss record 6 of 26
==10975==    at 0x4020626: malloc (vg_replace_malloc.c:149)
==10975==    by 0x4280E9C: g_malloc (in /targets/OSSO_1.1_X86/usr/lib/libglib-2.0.so.0.1200.12)
==10975==    by 0x42943F4: g_strsplit (in /targets/OSSO_1.1_X86/usr/lib/libglib-2.0.so.0.1200.12)
==10975==    by 0x6B94B8C: gst_rtp_h264_depay_setcaps (gstrtph264depay.c:238)
==10975==    by 0x4A4A5B9: gst_base_rtp_depayload_setcaps (gstbasertpdepayload.c:227)
==10975==    by 0x4070C0A: gst_pad_set_caps (gstpad.c:2363)
==10975==    by 0x407302E: gst_pad_chain_unchecked (gstpad.c:2417)
==10975==    by 0x40738E5: gst_pad_push (gstpad.c:3617)
==10975==    by 0x45EA7C9: gst_type_find_element_chain (gsttypefindelement.c:570)
==10975==    by 0x407306E: gst_pad_chain_unchecked (gstpad.c:3451)
==10975==    by 0x40738E5: gst_pad_push (gstpad.c:3617)
==10975==    by 0x405F109: gst_proxy_pad_do_chain (gstghostpad.c:191)

The params -array is not freed. Attached patch fixes this.
Comment 1 Tommi Myöhänen 2007-11-15 11:12:46 UTC
Created attachment 99135 [details] [review]
Patch that fixes small memory leak in gstrtph264depay.c
Comment 2 Wim Taymans 2007-11-15 17:01:47 UTC
        Patch by: Tommi Myöhänen  <ext-tommi dot myohanen at nokia dot com>

        * gst/rtp/gstrtph264depay.c: (gst_rtp_h264_depay_setcaps):
        Fix small leak. Fixes #497017.