After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 496983 - [PATCH] rtspsrc leaks pads
[PATCH] rtspsrc leaks pads
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-11-15 08:41 UTC by Tommi Myöhänen
Modified: 2007-11-15 17:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to rtspsrc.c that fixes three pad leaks (1.26 KB, patch)
2007-11-15 08:42 UTC, Tommi Myöhänen 		committed Details | Review

Description Tommi Myöhänen 2007-11-15 08:41:39 UTC 
RTSP source element leaks pads in following situations:

1. Channel pads: when using TCP transport and gst_rtspsrc_stream_free() is called. This happens because stream->channelpad[i] is unref'ed only if stream->udpsrc[i] != NULL. In TCP transport this is false.

2. rtcppad is created in gst_rtspsrc_stream_configure_tcp() and gst_rtspsrc_stream_configure_udp_sink() functions, but never unref'ed.

3. In gst_rtspsrc_stream_configure_tcp() a "template" GstPadTemplate is created (if (src->session)), but it is not unref'ed.

Attached patch fixes these leaks.
Comment 1 Tommi Myöhänen 2007-11-15 08:42:31 UTC 
Created attachment 99129 [details] [review]
Patch to rtspsrc.c that fixes three pad leaks
Comment 2 Wim Taymans 2007-11-15 17:35:19 UTC 
        Patch by: Tommi Myöhänen  <ext-tommi dot myohanen at nokia dot com>

        * gst/rtsp/gstrtspsrc.c: (gst_rtspsrc_stream_free),
        (gst_rtspsrc_stream_configure_tcp):
        Fix 3 pad leaks. Fixes #496983.