After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 496947 - api.[ch] - what is it good for?
api.[ch] - what is it good for?
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
trunk
Other Linux
: Normal enhancement
: ---
Assigned To: Thomas Thurman
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2007-11-15 03:02 UTC by Thomas Thurman
Modified: 2007-11-16 03:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Changes necessary to other files in order to support not having api.[ch] (1.19 KB, patch)
2007-11-15 03:03 UTC, Thomas Thurman
committed Details | Review

Description Thomas Thurman 2007-11-15 03:02:46 UTC
api.[ch] exports two functions, meta_get_pango_context and meta_get_x_pixel. Neither appears to be used anywhere. The enum MetaUIState is also exported by api.h and not used. (Google codesearch confirms that they are not used anywhere on the web.) On the other hand, MetaUIColors is used by colors.[ch], but it can be moved into that file; the patch is attached.

This saves us two files, which seems a good plan to me. Does anyone know whether these files are good for anything?
Comment 1 Thomas Thurman 2007-11-15 03:03:41 UTC
Created attachment 99122 [details] [review]
Changes necessary to other files in order to support not having api.[ch]
Comment 2 Thomas Thurman 2007-11-15 03:04:25 UTC
(Um, I failed actually to say anywhere, "...or shall we nuke it?")
Comment 3 Havoc Pennington 2007-11-15 18:43:52 UTC
Nothing in ChangeLog. 
svn log looks like this:

------------------------------------------------------------------------
r12 | rhp | 2001-06-03 17:39:57 -0400 (Sun, 03 Jun 2001) | 2 lines

...

------------------------------------------------------------------------
r11 | rhp | 2001-06-03 14:33:59 -0400 (Sun, 03 Jun 2001) | 2 lines

...

------------------------------------------------------------------------
r7 | rhp | 2001-06-02 00:14:18 -0400 (Sat, 02 Jun 2001) | 2 lines

...

------------------------------------------------------------------------
r6 | rhp | 2001-05-31 23:00:01 -0400 (Thu, 31 May 2001) | 2 lines

...



Comment 4 Thomas Thurman 2007-11-15 18:54:16 UTC
r6?! Good grief, I feel we're opening a tomb which will lead to the death of Lord Carnarvon or something.

I will get rid of this, then. Everything works fine without it.
Comment 5 Havoc Pennington 2007-11-15 19:03:03 UTC
You might fix the comment that mentions "GTK UI slave" - I think for a very short time the GTK stuff was out-of-process.
Comment 6 Thomas Thurman 2007-11-16 03:08:11 UTC
Okay, thanks.

Closed:
http://svn.gnome.org/viewvc/metacity?view=revision&revision=3401