GNOME Bugzilla – Bug 496947
api.[ch] - what is it good for?
Last modified: 2007-11-16 03:08:11 UTC
api.[ch] exports two functions, meta_get_pango_context and meta_get_x_pixel. Neither appears to be used anywhere. The enum MetaUIState is also exported by api.h and not used. (Google codesearch confirms that they are not used anywhere on the web.) On the other hand, MetaUIColors is used by colors.[ch], but it can be moved into that file; the patch is attached. This saves us two files, which seems a good plan to me. Does anyone know whether these files are good for anything?
Created attachment 99122 [details] [review] Changes necessary to other files in order to support not having api.[ch]
(Um, I failed actually to say anywhere, "...or shall we nuke it?")
Nothing in ChangeLog. svn log looks like this: ------------------------------------------------------------------------ r12 | rhp | 2001-06-03 17:39:57 -0400 (Sun, 03 Jun 2001) | 2 lines ... ------------------------------------------------------------------------ r11 | rhp | 2001-06-03 14:33:59 -0400 (Sun, 03 Jun 2001) | 2 lines ... ------------------------------------------------------------------------ r7 | rhp | 2001-06-02 00:14:18 -0400 (Sat, 02 Jun 2001) | 2 lines ... ------------------------------------------------------------------------ r6 | rhp | 2001-05-31 23:00:01 -0400 (Thu, 31 May 2001) | 2 lines ...
r6?! Good grief, I feel we're opening a tomb which will lead to the death of Lord Carnarvon or something. I will get rid of this, then. Everything works fine without it.
You might fix the comment that mentions "GTK UI slave" - I think for a very short time the GTK stuff was out-of-process.
Okay, thanks. Closed: http://svn.gnome.org/viewvc/metacity?view=revision&revision=3401