After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 496399 - [oggdemux] not erroring out when no chain can be found
[oggdemux] not erroring out when no chain can be found
Status: RESOLVED DUPLICATE of bug 525665
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-11-13 10:17 UTC by Edward Hervey
Modified: 2009-03-12 07:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (1.56 KB, patch)
2007-11-13 10:17 UTC, Edward Hervey 		none Details | Review
update patch (1.93 KB, patch)
2007-11-13 11:12 UTC, Edward Hervey 		none Details | Review

Description Edward Hervey 2007-11-13 10:17:17 UTC 
This is a corner case, but still a pain to handle.

In gst_ogg_demux_read_chain, there is a possibility that it will not find a valid chain, but will return with GST_FLOW_OK.

This patch makes sure that in those cases it returns GST_FLOW_ERROR so the streaming thread can stop properly.

Else it carries on and randomly leads to crashes.
Comment 1 Edward Hervey 2007-11-13 10:17:44 UTC 
Created attachment 99016 [details] [review]
fix
Comment 2 Edward Hervey 2007-11-13 11:12:39 UTC 
Created attachment 99019 [details] [review]
update patch

The previous patch was somewhat wrong. This one fixes the issue at the gst_ogg_demux_find_chains() level. Doesn't bring any regressions after testing it on all .ogg files in the testsuite.
Comment 3 Edward Hervey 2009-03-12 07:07:05 UTC 

*** This bug has been marked as a duplicate of 525665 ***