After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 496125 - Shade/Unshade/Fullscreen Titlebarbuttons
Shade/Unshade/Fullscreen Titlebarbuttons
Status: RESOLVED OBSOLETE
Product: metacity
Classification: Other
Component: general
2.21.x
Other All
: Normal enhancement
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2007-11-12 11:47 UTC by Christopher Roy Bratusek
Modified: 2007-11-13 01:37 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement



Description Christopher Roy Bratusek 2007-11-12 11:47:36 UTC
The Shade/Unshade/Fullscreen Actions are currently only available as Shortcut or Titlebaractions, having them as button would be nice. Of course pressing F11 is not a big deal, but some apps might already use this key. Shading and Unshading is already available as titlebaraction, but as button the titlebaraction could be used for something different.
Comment 1 Martin Meyer 2007-11-12 16:31:00 UTC
According to HIG (section 2.4.1), ctrl+f11 is designated as the full screen key event. It's up to individual apps to follow this, metacity is only responsible for the act of putting the window in fullscreen mode when asked to do so AFAIK.

There isn't a key specified in the HIG for shade/unshade. Should we get it added to HIG if we want it in Metacity, or can Metacity do it anyway? How many people still use shading these days?
Comment 2 Christopher Roy Bratusek 2007-11-12 17:30:21 UTC
Metacity already supports shading/unshading, that's why I asked for the titlebarbutton.
Comment 3 Thomas Thurman 2007-11-12 17:35:06 UTC
Um, Metacity has a titlebar button for shading and unshading; it has for a while.
Comment 4 Christopher Roy Bratusek 2007-11-12 17:50:28 UTC
really? how is it called? I tried both shade and toggle_shade in "/apps/metacity/general/button_layout" but both didn't work
Comment 5 Christopher Roy Bratusek 2007-11-12 18:30:30 UTC
you're right. I tried with the Schwermetall, Clearlooks and Simple Themes, but it didn't work, now I tried with the Crux Theme and it works. Dump me.
Comment 6 Thomas Thurman 2007-11-12 18:33:48 UTC
It's "shade", but you need to be using a theme which defines how the shade and unshade buttons should be drawn (i.e. one which ships a metacity-theme-2.xml file, and most of them don't), otherwise there's no reasonable way it could work; bug 96229 was where this was introduced.
Comment 7 Thomas Thurman 2007-11-12 18:34:57 UTC
Do you still want the fullscreen button?
Comment 8 Christopher Roy Bratusek 2007-11-12 18:37:04 UTC
Yes, that would be nice.

BTW: stick, above, shade, minimize, maximize, close and menu are available, right? or did I miss one?
Comment 9 Elijah Newren 2007-11-13 01:35:02 UTC
Um, why would having a fullscreen button make any sense?  Isn't the point of having the buttons in the titlebar to let users toggle states that they don't know they keybindings for?  Users aren't going to be able to unfullscreen their application once it's in fullscreen state because the titlebar won't be shown with the appropriate buttons.  You may then be stuck in a situation where users don't know how to recover from what they just did.
Comment 10 Thomas Thurman 2007-11-13 01:37:57 UTC
I do agree with this point; I just wanted to make sure I understood what Christopher was asking for (so I knew, say, whether this was wontfix or dependent on the theme v3 tracker bug or whatever).