After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 495107 - Handle print dialog responses correctly
Handle print dialog responses correctly
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: printing
2.20.x
Other Linux
: Normal blocker
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-11-08 20:41 UTC by Pedro Villavicencio
Modified: 2008-03-09 12:41 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20

Attachments
Fix (495 bytes, patch)
2008-03-09 12:40 UTC, Wouter Bolsterlee (uws) 		committed Details | Review

Description Pedro Villavicencio 2007-11-08 20:41:39 UTC 
This bug has been reported here:

https://bugs.launchpad.net/ubuntu/+source/evince/+bug/160589

"Steps to reproduce:

0. Ensure printer is connected and working
1. Open PDF in evince
2. File -> print
3. Press escape

Expected result: print dialog closes, printer stays silent

Actual result: print dialog closes, printer prints document
This is counter-intuitive.
"

Thanks.
Comment 1 Bruno Boaventura 2007-11-10 16:23:21 UTC 
Pedro, I can't reproduce on Ubuntu Gutsy + Evince 2.20.1
Comment 2 Gernot Klingler 2007-12-04 11:34:41 UTC 
I can confirm the problem with evince 2.20.1 on gentoo and ubuntu gutsy.
Comment 3 Eugen Dedu 2008-03-02 20:32:08 UTC 
I confirm this bug on debian 2.20.2 (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=462623).  Please fix it, it should be pretty easy.

Best regards,
Eugen Dedu
Comment 4 Eugen Dedu 2008-03-07 17:31:18 UTC 
Hi,

The culprit is surely the line shell/ev-window.c:2223
	if (response == GTK_RESPONSE_CANCEL) {
which should be changed to
	if (response == GTK_RESPONSE_CANCEL || response == GTK_RESPONSE_NONE) {

Can someone check this?

Greetings,
Eugen Dedu
Comment 5 Carlos Garcia Campos 2008-03-08 20:04:33 UTC 
Fixed in trunk, thank you very much.
Comment 6 Wouter Bolsterlee (uws) 2008-03-09 12:37:40 UTC 
Not fixed properly. Reopening.
Comment 7 Wouter Bolsterlee (uws) 2008-03-09 12:38:48 UTC 
Raising severity, currently printing is broken since the "Print" button signal is not handled correctly, assuming the print dialog was cancelled while in fact "Print" was pressed...
Comment 8 Wouter Bolsterlee (uws) 2008-03-09 12:40:50 UTC 
Created attachment 106894 [details] [review]
Fix

This fixes printing.
Comment 9 Wouter Bolsterlee (uws) 2008-03-09 12:41:14 UTC 
2008-03-09  Wouter Bolsterlee  <wbolster@svn.gnome.org>

    * shell/ev-window.c (ev_window_print_dialog_response_cb):

    Bug 495107 – Handle print dialog responses correctly

    Correctly handle print dialog response. Properly fixes
    the above mentioned bug.