After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 494318 - R1C1 relative references entered in GoTo dialog/selection descriptor should be interpreted relative to active cell
R1C1 relative references entered in GoTo dialog/selection descriptor should b...
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
git master
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2007-11-06 21:34 UTC by Oliver Burnett-Hall
Modified: 2007-11-10 01:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Interpret relative references with respect to active cell (5.92 KB, patch)
2007-11-06 21:52 UTC, Oliver Burnett-Hall
accepted-commit_now Details | Review

Description Oliver Burnett-Hall 2007-11-06 21:34:41 UTC
Entering a R1C1 relative reference in the GoTo dialog should result in the active cell being calculated relative to the currently active cell.

For example: if the current selection is R2C2:R4C4 with R3C3 active, if you enter RC in the selection descriptor the new selection should be R3C3.  But this doesn't happen -- the top-left corner of the first range in the selection is used instead of the active cell, so R2C2 becomes active.
Comment 1 Oliver Burnett-Hall 2007-11-06 21:52:27 UTC
Created attachment 98690 [details] [review]
Interpret relative references with respect to active cell

The bulk of this patch is breaking up wb_control_parse_and_jump(), which was getting very big and doing several things.

The bugfix part of it is the call to (new function) eval_pos_init_editpos(&ep, sv) instead of the call to eval_pos_init_pos(&ep, sheet, &first_range->start).
Comment 2 Jody Goldberg 2007-11-09 14:29:52 UTC
Comment on attachment 98690 [details] [review]
Interpret relative references with respect to active cell

The fix is correct, and the split makes sense.  As long as you are in there, please add a quick sentence or two of docs for each of the routines, then commit.
Comment 3 Morten Welinder 2007-11-10 01:11:03 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.