After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 493547 - Missing -I flags for X11
Missing -I flags for X11
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: build
1.20.x
Other Mac OS
: Immediate normal
: ---
Assigned To: Li Yuan
Li Yuan
Depends on:
Blocks:
 
 
Reported: 2007-11-04 22:56 UTC by Daniel Macks
Modified: 2007-12-03 06:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (454 bytes, patch)
2007-11-28 06:48 UTC, Li Yuan 		committed Details | Review
patch2 (306 bytes, patch)
2007-11-28 08:30 UTC, Li Yuan 		committed Details | Review

Description Daniel Macks 2007-11-04 22:56:32 UTC 
Compiling at-spi-1.20.1 fails in atk-bridge:

/bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I..  -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare  -DORBIT2=1 -I/sw/include/glib-2.0 -I/sw/lib/glib-2.0/include -I/sw/include/atk-1.0 -I/sw/include/orbit-2.0 -I/sw/include/bonobo-activation-2.0 -I/sw/include/libbonobo-2.0    -I/sw/lib/pango-ft219/include/pango-1.0 -I/sw/lib/pango-ft219/include -I/sw/lib/freetype219/include/freetype2 -I/sw/lib/freetype219/include -I/sw/lib/fontconfig2/include -I/sw/include  -Os -c -o accessible.lo accessible.c
 gcc -DHAVE_CONFIG_H -I. -I. -I.. -I.. -I.. -Wall -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wno-sign-compare -DORBIT2=1 -I/sw/include/glib-2.0 -I/sw/lib/glib-2.0/include -I/sw/include/atk-1.0 -I/sw/include/orbit-2.0 -I/sw/include/bonobo-activation-2.0 -I/sw/include/libbonobo-2.0 -I/sw/lib/pango-ft219/include/pango-1.0 -I/sw/lib/pango-ft219/include -I/sw/lib/freetype219/include/freetype2 -I/sw/lib/freetype219/include -I/sw/lib/fontconfig2/include -I/sw/include -Os -c accessible.c  -fno-common -DPIC -o .libs/accessible.o
In file included from ../libspi/devicelistener.h:30,
                 from ../libspi/libspi.h:46,
                 from accessible.c:30:
../libspi/keymasks.h:27:22: error: X11/Xlib.h: No such file or directory

It uses X11 headers but doesn't pass the -I to find them. Previous versions of the GNOME suite inherited that flag from dependent libraries via pkg-config, but not any more. We need $(X_CFLAGS) in INCLUDES in atk-bridge/Makefile.am
Comment 1 Li Yuan 2007-11-28 06:48:40 UTC 
Created attachment 99755 [details] [review]
patch
Comment 2 Li Yuan 2007-11-28 06:51:28 UTC 
Does the patch fix your problem?
Comment 3 Li Yuan 2007-11-28 08:30:09 UTC 
Created attachment 99764 [details] [review]
patch2

please apply this patch too.
Comment 4 Daniel Macks 2007-12-01 20:57:18 UTC 
There are lots of Makefile.am in at-spi; could you provide more detailed paths in those diffs?
Comment 5 Daniel Macks 2007-12-01 21:47:25 UTC 
Found 'em...libspi/Makefile.am and atk-bridge/Makefile.am respectively. Yes, with those two applied (well, their equilvalent applied to the Makefile.in) at-spi-1.20.1 now builds completely (modulo the python bindings, which I patched out because I don't yet have python>=2.4) on my OS X 10.3 machine and passes its self-tests.