After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 492695 - Huge tooltip
Huge tooltip
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-11-02 13:32 UTC by Bastien Nocera
Modified: 2007-11-03 01:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1.77 KB, patch)
2007-11-02 19:41 UTC, Cosimo Cecchi
committed Details | Review

Description Bastien Nocera 2007-11-02 13:32:09 UTC
1. Bookmark a scriplet such as the one at:
http://1024k.de/bookmarklets/video-bookmarklets.html
2. Add it to your bookmarks bar
3. Hover the bookmark and see a _huge_ tooltip

Epiphany should probably not show a tooltip if the URI starts with javascript: or at least clip it.
Comment 1 Bastien Nocera 2007-11-02 13:32:20 UTC
I'm using 2.20.1
Comment 2 Cosimo Cecchi 2007-11-02 19:41:35 UTC
Created attachment 98408 [details] [review]
proposed patch

Attached patch makes Epiphany display "Javascript scriptlet" for the tooltip when bookmarking something with location property string beginning with "javascript:".
Comment 3 Christian Persch 2007-11-02 20:56:00 UTC
Thanks!
Comment 4 Bastien Nocera 2007-11-03 00:46:01 UTC
Comment on attachment 98408 [details] [review]
proposed patch

<snip>
>+		text = g_strdup ("Javascript scriptlet");

That should be translated.
Comment 5 Cosimo Cecchi 2007-11-03 01:26:45 UTC
Committed to trunk with the string correctly marked for translation as in last comment. Thanks, closing as FIXED.

------------------------------------------------------------------------
r7616 | cosimoc | 2007-11-03 02:23:19 +0100 (sab, 03 nov 2007) | 4 lines

Display "Javascript scriptlet" string as tooltip for bookmark action instead
of the whole javascript code when bookmarking a scriptlet.
Fix bug #492695.