GNOME Bugzilla – Bug 492406
Crasher in libgstdshow on Windows/MSVC
Last modified: 2007-11-04 11:12:33 UTC
Please describe the problem: gst-plugins-bad doesn't build warning-free with Windows/MSVC (MSVS2005). Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Please disregard the original description, got confused by a context-switch at work. :) gst-plugins-bad's libgstdshow has a crasher in the gstdshowfakesink's constructor when it calls the base class constructor with the HRESULT * argument being NULL. The base class implementation is some sample code in the Windows SDK, so presumably the original author (Sebastien) was using an older version of the SDK where the base class constructor was NULL-safe.
Created attachment 98333 [details] [review] Fix for the crasher caused by the base class constructor not necessarily being NULL-safe.
Created attachment 98334 [details] [review] Fix a couple of trivial warnings in dshowsrcwrapper while we're at it.
Thanks, committed: 2007-11-04 Tim-Philipp Müller <tim at centricular dot net> Patch by: Ole André Vadla Ravnås <ole.andre.ravnas@tandberg.com> * gst-libs/gst/dshow/gstdshowfakesink.cpp: (CDshowFakeSink.CDshowFakeSink): * gst-libs/gst/dshow/gstdshowfakesink.h: (CDshowFakeSink.m_hres): Fix crasher in constructor due to the base class's constructor not necessarily being NULL-safe (depends on the SDK version used apparently; #492406). * sys/dshowsrcwrapper/gstdshowaudiosrc.c: (gst_dshowaudiosrc_prepare): * sys/dshowsrcwrapper/gstdshowvideosrc.c: (gst_dshowvideosrc_set_caps): Fix a couple of MSVC compiler warnings (#492406).