GNOME Bugzilla – Bug 492388
Build issues on Windows/MSVC
Last modified: 2007-11-02 21:16:45 UTC
Please describe the problem: gst-plugins-good doesn't build properly with Windows/MSVC (MSVS2005). Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 98322 [details] [review] Fixed includes for MSVC. There's no unistd.h and sys/time.h when building in an MSVC environment, so we need to check for HAVE_{UNISTD_H,SYS_TIME_H}. Because of this we need to do two changes: 1. Update configure.ac to check for sys/time.h so that HAVE_SYS_TIME_H gets defined in config.h for systems that have it. 2. Move the includes from the header file to the C file for each case, as we shouldn't include "config.h" in the header-files (even if they're not gonna get installed).
Comment on attachment 98322 [details] [review] Fixed includes for MSVC. Forgot to mention that this has been tested with MSVS 2005 and on Linux with autotools and gcc 4.1.3 (a stock Ubuntu Gutsy system), gst/udp builds without warnings for both cases.
Created attachment 98323 [details] [review] GLib doesn't have a pipe() macro anymore starting with 2.14.0.
Thanks, committed: 2007-11-02 Tim-Philipp Müller <tim at centricular dot net> Patch by: Ole André Vadla Ravnås <ole.andre.ravnas@tandberg.com> * configure.ac: * gst/udp/gstdynudpsink.c: * gst/udp/gstdynudpsink.h: * gst/udp/gstmultiudpsink.c: * gst/udp/gstmultiudpsink.h: * gst/udp/gstudpsink.c: * gst/udp/gstudpsink.h: Fix includes for MSVC and GLib-2.14.0 (#492388). * gst/udp/gstudpsrc.c: (gst_udpsrc_start): No more pipe define since GLib-2.14.0, need to use _pipe() directly.