After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 492388 - Build issues on Windows/MSVC
Build issues on Windows/MSVC
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.6
Other Windows
: Normal normal
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-11-01 15:52 UTC by Ole André Vadla Ravnås
Modified: 2007-11-02 21:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fixed includes for MSVC. (3.12 KB, patch)
2007-11-01 16:01 UTC, Ole André Vadla Ravnås
committed Details | Review
GLib doesn't have a pipe() macro anymore starting with 2.14.0. (574 bytes, patch)
2007-11-01 16:08 UTC, Ole André Vadla Ravnås
committed Details | Review

Description Ole André Vadla Ravnås 2007-11-01 15:52:16 UTC
Please describe the problem:
gst-plugins-good doesn't build properly with Windows/MSVC (MSVS2005).

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Ole André Vadla Ravnås 2007-11-01 16:01:00 UTC
Created attachment 98322 [details] [review]
Fixed includes for MSVC.

There's no unistd.h and sys/time.h when building in an MSVC environment, so we need to check for HAVE_{UNISTD_H,SYS_TIME_H}. Because of this we need to do two changes:
1. Update configure.ac to check for sys/time.h so that HAVE_SYS_TIME_H gets defined in config.h for systems that have it.
2. Move the includes from the header file to the C file for each case, as we shouldn't include "config.h" in the header-files (even if they're not gonna get installed).
Comment 2 Ole André Vadla Ravnås 2007-11-01 16:03:26 UTC
Comment on attachment 98322 [details] [review]
Fixed includes for MSVC.

Forgot to mention that this has been tested with MSVS 2005 and on Linux with autotools and gcc 4.1.3 (a stock Ubuntu Gutsy system), gst/udp builds without warnings for both cases.
Comment 3 Ole André Vadla Ravnås 2007-11-01 16:08:29 UTC
Created attachment 98323 [details] [review]
GLib doesn't have a pipe() macro anymore starting with 2.14.0.
Comment 4 Tim-Philipp Müller 2007-11-02 21:16:45 UTC
Thanks, committed:

 2007-11-02  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Ole André Vadla Ravnås  <ole.andre.ravnas@tandberg.com>

        * configure.ac:
        * gst/udp/gstdynudpsink.c:
        * gst/udp/gstdynudpsink.h:
        * gst/udp/gstmultiudpsink.c:
        * gst/udp/gstmultiudpsink.h:
        * gst/udp/gstudpsink.c:
        * gst/udp/gstudpsink.h:
          Fix includes for MSVC and GLib-2.14.0 (#492388).

        * gst/udp/gstudpsrc.c: (gst_udpsrc_start):
          No more pipe define since GLib-2.14.0, need to use _pipe() directly.