After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 492260 - Crash on rotate on x86_64
Crash on rotate on x86_64
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
2.10.x
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2007-11-01 03:29 UTC by Ignacy Gawędzki
Modified: 2007-11-30 20:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (330 bytes, patch)
2007-11-01 03:31 UTC, Ignacy Gawędzki 		committed Details | Review

Description Ignacy Gawędzki 2007-11-01 03:29:04 UTC 
After applying the patch attached to my report in #492258, I found and fixed a crash that appears only on platforms with size_t != unsigned int.
Comment 1 Ignacy Gawędzki 2007-11-01 03:31:11 UTC 
Created attachment 98295 [details] [review]
proposed patch
Comment 2 Michael Chudobiak 2007-11-01 12:26:04 UTC 
Hmm, this one is a bit out of my league - does g_malloc want to see unsigned int, size_t, or gulong? What about the other unsigned ints in that file?

Jef or Paolo, can you check this?

- Mike
Comment 3 Michael Chudobiak 2007-11-01 12:37:57 UTC 
Anyway, I've committed Ignacy's patch (thank you!) to fix the crash, but someone clever than myself should check that there aren't other typing problems lurking in jpegtran.c.

http://svn.gnome.org/viewvc/gthumb?view=revision&revision=2043
http://svn.gnome.org/viewvc/gthumb?view=revision&revision=2044

- Mike