GNOME Bugzilla – Bug 492033
Cursor can't change to the correct icon when mouse is on edge of the window
Last modified: 2012-05-14 19:09:10 UTC
Please describe the problem: On client, approach mouse to the edge of the window, such as a terminal or a firefox window. Observe the status of cursor in this process: On server, cursor icon changes from a normal arrow icon to a special icon, which shows you are at the edge of this window. On client, this function doesn't work. Both server and client machines are running Solaris. Steps to reproduce: 1. Enable remote desktop on server side: Launch->Preferences->Remote Desktop Choose "Allow other users to view your desktop", "Allow other users to control your desktop" Press "Close" 2. On client side, access server from firefox Start up firefox, type "http://$Server_Hostname:5800" in URL, 3. Open a terminal in client, approach mouse to the edge of the window. observe the status of cursor in this process. Actual results: On server, cursor icon changes from a normal arrow icon to a special icon, which shows you are at the edge of this window. On client, this function doesn't work. Expected results: Client's behavior should be the same as server's. Does this happen every time? yes Other information:
Yes, this is because vino hard-codes the cursor image and hasn't been updated to use XFixes support for this. Using XFixesGetCursorImage in vino-cursor.c and vino-server.c, an rfb cursor could be generated with a little refactoring.
Created attachment 210862 [details] [review] Implement suggestion from comment #1
Created attachment 210863 [details] [review] Patch that fixes the cursor bounds computation Found those problems while debugging the cursor case with libefence.
Created attachment 210864 [details] [review] Patch that fixes iteration on the cursor->source[] array
Comment on attachment 210862 [details] [review] Implement suggestion from comment #1 Committed and pushed to master as commit 962af8d7c241d66214d6755d9ed4513e6504cd1b.
Comment on attachment 210863 [details] [review] Patch that fixes the cursor bounds computation Committed and pushed to master as commit b2cc3670b909fd1fd2e7f475b7cc39dfcc56ac63.
Comment on attachment 210864 [details] [review] Patch that fixes iteration on the cursor->source[] array Committed and pushed to master as commit 8bbbfce1785423d6c1af2f3f0588c234e8f96488, thanks!