After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 491323 - Extend RTP MPEG-TS payloader to handle large RTP payload packets
Extend RTP MPEG-TS payloader to handle large RTP payload packets
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.6
Other All
: Normal enhancement
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-10-29 10:23 UTC by Jordi Jaen Pallares
Modified: 2007-11-15 18:19 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
patch to increase the RTP payload to 1316 bytes (6.36 KB, patch)
2007-10-29 11:00 UTC, Jordi Jaen Pallares
needs-work Details | Review
Updated patch with wtay suggestions. (5.22 KB, patch)
2007-10-29 14:22 UTC, Jordi Jaen Pallares
committed Details | Review

Description Jordi Jaen Pallares 2007-10-29 10:23:43 UTC
Currently, the RTP MPEG-TS payloader component 'rtpmp2tpay' packs only one MPT frame of 188 bytes in the RTP packet payload. The idea is to increase the payload size of to 1316 bytes. 

As an idea, the number of MPT frames in the payload could be a configurable parameter from 1 to 7 (the maximum allowed by the MTU).
Comment 1 Jordi Jaen Pallares 2007-10-29 11:00:42 UTC
Created attachment 98090 [details] [review]
patch to increase the RTP payload to 1316 bytes

First patch attempt to provide functionality.
Comment 2 Wim Taymans 2007-10-29 11:15:56 UTC
- packetsize in the caps for video/mpegts means the size of the transport stream packet, which can be 188 or 194 (with timestamp). A packetsize of >1000 is not allowed.

- you should probably just fill up to the MTU (see rtpmpapay for an example)
Comment 3 Jordi Jaen Pallares 2007-10-29 14:22:20 UTC
Created attachment 98107 [details] [review]
Updated patch with wtay suggestions.

Left the payload size as 188.
Removed hardcoded variables.
Changed "filled buffer" condition.
Comment 4 Wim Taymans 2007-11-15 18:19:22 UTC
        Patch by: Jordi Jaen Pallares <jordijp at gmail dot com>

        * gst/rtp/gstrtpmp2tpay.c: (gst_rtp_mp2t_pay_class_init),
        (gst_rtp_mp2t_pay_init), (gst_rtp_mp2t_pay_finalize),
        (gst_rtp_mp2t_pay_flush), (gst_rtp_mp2t_pay_handle_buffer):
        * gst/rtp/gstrtpmp2tpay.h:
        Fill the MTU with as many packets as possible. Fixes #491323.