GNOME Bugzilla – Bug 490283
[multifilsrc] move to -good
Last modified: 2008-02-08 04:25:13 UTC
After some prodding, it's time to move multifilesrc/sink to -good.
Recently updated in CVS.
I'm a bit dubious about the test that does a g_mkdir in the current dir - perhaps it should use g_get_tmp_dir and mkdtemp() ? The docs for multifilesink should have an example launch line, and a better explanation of the 'location' property format. The element details string for both elements could be a little more descriptive, like "Read a sequentially named set of files into buffers" perhaps. Otherwise looks good for move.
Random comments: - I wonder if it would make sense to use g_file_get_contents() for multifilesrc, it's likely to provide better error checking (this should be decided before the move, since it determines the filename encoding on win32). - same for multifilesink: use g_file_set_contents()? - would be nice if it was possible (in code, at least), to make multifilesrc read in a bunch of files that doesn't follow the rigid filename + index pattern. This could be done either by setting a fixed G_TYPE_STRV-type property which takes a list in advance, or by emitting some kind of "next" signal from the create function (I guess notify::index would do too, but it's not really particularly discoverable or intuitive), which the app could then hook up to and set a new filename. This stuff can always be added later of course. - same for multifilesink - multifilesink should probably error out, or at least send a warning message, if it receives more than one new-segment event. - seems to have some copy'n'paste leftovers (the lseek defines etc.) Otherwise +1 for move.
- Changed test to create a real tempdir. - Fixed element detail string. - Changed to use g_file_[gs]et_contents(). - Removed lseek defines. Not yet done: - Better docs for location property and example line for multifilesink. Won't fix: - filename lists. I haven't seen a real need for this. I initially wanted to do this, but the use cases that I came up with would be better handled by the application feeding data using appsrc. multifilesrc/sink is mostly meant to be a gst-launch element.
Plugin moved in CVS: 2008-02-08 Jan Schmidt <jan.schmidt@sun.com> * configure.ac: * docs/plugins/Makefile.am: * docs/plugins/gst-plugins-good-plugins-docs.sgml: * docs/plugins/gst-plugins-good-plugins-sections.txt: * docs/plugins/gst-plugins-good-plugins.args: * docs/plugins/gst-plugins-good-plugins.hierarchy: * docs/plugins/inspect/plugin-multifile.xml: * tests/check/Makefile.am: * tests/check/elements/.cvsignore: Move multifile plugin from -bad. Fixes: #490283