After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 489273 - Need a ref() on the override for Relation.getTarget()
Need a ref() on the override for Relation.getTarget()
Status: RESOLVED OBSOLETE
Product: pyatspi2
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: At-spi maintainer(s)
At-spi maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-10-23 05:55 UTC by Eitan Isaacson
Modified: 2019-03-27 20:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed fix (27.53 KB, patch)
2007-10-23 05:55 UTC, Eitan Isaacson
committed Details | Review
Fix (423 bytes, patch)
2007-10-23 06:58 UTC, Eitan Isaacson
committed Details | Review

Description Eitan Isaacson 2007-10-23 05:55:08 UTC
The object that is retrieved with Relation.getTarget() needs a ref().
Comment 1 Eitan Isaacson 2007-10-23 05:55:55 UTC
Created attachment 97697 [details] [review]
Proposed fix
Comment 2 Eitan Isaacson 2007-10-23 06:00:46 UTC
I committed this patch both to trunk and to gnome-2-20.
Comment 3 Eitan Isaacson 2007-10-23 06:58:11 UTC
Created attachment 97702 [details] [review]
Fix

The previous patch was wrong, this is what was committed.
Comment 4 SteveLee 2007-10-23 12:10:33 UTC
I raised a Minefield bug which has a test script
https://bugzilla.mozilla.org/show_bug.cgi?id=400814

Latest r958 in SVN fixes it for me
Comment 5 Eitan Isaacson 2007-11-08 18:54:41 UTC
With stuff I know now, I am not convinced that ref should be here.
Comment 6 André Klapper 2012-02-26 10:45:14 UTC
[Resetting QA Contact to newly introduced "at-spi-maint@gnome.bugs". 
Reason: So far it was impossible to watch changes in at-spi bug reports without following all the specific persons (Li Yuan, Bill Haneman, Jeff Wai, ...) and also their activity outside of at-spi reports.

IMPORTANT: Anyone interested in following all bug activity (including all maintainers) must watch the "at-spi-maint@gnome.bugs" dummy user by adding it to the 'Users to watch' list under Preferences->Email preferences. This is also the default procedure nowadays in GNOME when setting up new products.]
Comment 7 André Klapper 2013-08-14 10:08:45 UTC
[Mass-resetting default assignee, see bug 705890. Please reclaim this bug report by setting the assignee to yourself if you still plan to work on this. Thanks!]
Comment 8 Magdalen Berns (irc magpie) 2014-11-14 21:50:37 UTC
I'm going to go ahead and close this because it concerns a very old version.
Feel free to open a new bug if the problem persists.