After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 489269 - valgrind option parameter invalid for valgrind 2.2
valgrind option parameter invalid for valgrind 2.2
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.13
Other Linux
: Normal minor
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-10-23 05:40 UTC by Jason Zhao
Modified: 2008-04-13 20:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
check.mak.patch (332 bytes, patch)
2007-10-23 05:41 UTC, Jason Zhao
reviewed Details | Review

Description Jason Zhao 2007-10-23 05:40:21 UTC
on linux, "--leak-check=full" and "--gen-suppressions=all" are invalid on latest valgrind version.

Change valgrind option parameter.

Changed files:
common/check.mak

Motorola would like to contribute Gstreamer patch to the  Gstreamer open source community project. Please find attached the patch applicable for Gstreamer. For any questions, please feel free to contact (Zhao Liang "e3423c@motorola.com", Shi Ling "w20230@motorola.com").
Comment 1 Jason Zhao 2007-10-23 05:41:18 UTC
Created attachment 97690 [details] [review]
check.mak.patch
Comment 2 Tim-Philipp Müller 2007-10-26 13:42:30 UTC
> on linux, "--leak-check=full" and "--gen-suppressions=all" are invalid on
> latest valgrind version.

What valgrind version is that exactly?  I can't find any evidence of such a change in valgrind SVN (rev. 7036), ie. valgrind 3.3.0-SVN

Comment 3 Tim-Philipp Müller 2007-11-05 14:56:33 UTC
Closing this bug report as no further information has been provided. Please feel free to reopen this bug if you can provide the information asked for.
Thanks!
Comment 4 Julien MOUTTE 2008-01-03 12:12:36 UTC
Please provide us with the version of valgrind you are using so that we can detect it and adapt accordingly.

[This bug is part of Fluendo support for Motorola.]
Comment 5 Jason Zhao 2008-01-07 09:13:02 UTC
our valgrind is 2.2.0, no valgrind version check in gstreamer configure
Comment 6 Julien MOUTTE 2008-01-07 13:51:39 UTC
I can confirm that in version 2.2.0 leak-check had only the yes/no value pair. In latest version they've added full. It seems that full and yes are equivalent.

For gen-suppressions this is the same thing, all have been added. But in that case yes and all do not seem to have the same behavior.

Maybe we could require valgrind >= 3.0 to enable the valgrind features or we could detect valgrind versions and adapt the parameters.

Suggestions. ?
Comment 7 Jason Zhao 2008-01-08 02:06:28 UTC
I think detecting valgrind versions is better for us, because our linux version is restricted, we can make a change, submit patch.
Comment 8 Tim-Philipp Müller 2008-04-13 20:46:43 UTC
Thanks for the clarification. I've updated the requirements now:

 2008-04-13  Tim-Philipp Müller  <tim at centricular dot net>

        * m4/gst-args.m4:
        * m4/gst-valgrind.m4:
          Bump valgrind requirement to 3.0 (which was released in August 2005).
          Fixes #489269. Also, check for version >=REQ and not >REQ.