After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 487892 - [mpegtsparse] getting pat-info property before PAT is available crashes filter
[mpegtsparse] getting pat-info property before PAT is available crashes filter
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-10-18 13:11 UTC by Wai-Ming Ho
Modified: 2007-11-15 19:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch mpegtsparse.c to correctly initialize the pat-info property (1.36 KB, patch)
2007-10-18 13:15 UTC, Wai-Ming Ho 		none Details | Review
overrides the previously suggested patch (1.36 KB, patch)
2007-10-22 09:48 UTC, Wai-Ming Ho 		committed Details | Review

Description Wai-Ming Ho 2007-10-18 13:11:17 UTC 
When asking for the pat-info property before the filter starts or before the PAT is available, the plugin crashes.
Comment 1 Wai-Ming Ho 2007-10-18 13:15:50 UTC 
Created attachment 97417 [details] [review]
Patch mpegtsparse.c to correctly initialize the pat-info property

The patch ensures that the plugin does not crash when the property pat-info is queried before a PAT is available. It also ensures that the PAT info is cleared when the changing from PLAYING to READY.
Comment 2 Wai-Ming Ho 2007-10-22 09:48:49 UTC 
Created attachment 97595 [details] [review]
overrides the previously suggested patch

The previous patch 97417 introduces an undesirable side effect that makes the PAT info obsolete even if it wasn't. The correct approach is to remove the stream completely when the filter is stopped.
Comment 3 Wim Taymans 2007-11-15 19:03:36 UTC 
        Patch by: Wai-Ming Ho <webregbox at yahoo dot co dot uk>

        * gst/mpegtsparse/mpegtspacketizer.c: (foreach_stream_clear),
        (remove_all), (mpegts_packetizer_clear):
        Ensure that the plugin does not crash when the property pat-info is
        queried before a PAT is available. It also ensures that the PAT info is
        cleared when the changing from PLAYING to READY.
        Fixes #487892.