After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 487360 - motorola contribution for gstreamer framework performance optimization
motorola contribution for gstreamer framework performance optimization
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.13
Other Linux
: Normal minor
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-10-17 02:44 UTC by Jason Zhao
Modified: 2007-10-23 10:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for gstreamer-0.10.13 (35.74 KB, patch)
2007-10-17 02:45 UTC, Jason Zhao
none Details | Review
README (941 bytes, text/plain)
2007-10-17 02:51 UTC, Jason Zhao
  Details

Description Jason Zhao 2007-10-17 02:44:22 UTC
Motorola would like to contribute Gstreamer framework performance optimization patch to the  Gstreamer open source community project. Please find attached the patch (gstreamer-0.10.13.patch) applicable for GST framework (gstreamer-0.10.13) along with a README specifying applying the patch. For any questions, please feel free to contact (Zhao Liang "e3423c@motorola.com", Shi Ling "w20230@motorola.com").
Comment 1 Jason Zhao 2007-10-17 02:45:30 UTC
Created attachment 97320 [details] [review]
patch for gstreamer-0.10.13
Comment 2 Jason Zhao 2007-10-17 02:51:30 UTC
Created attachment 97323 [details]
README
Comment 3 Edward Hervey 2007-10-17 08:54:03 UTC
Hi, nice seeing patches coming from big corporations from Motorola !

The problem is that your patch is REALLY big and contains a lot of things. Could you split up that patch into smaller parts explaining for each:
* what the patch does
* how it improves performance
* what it changes in current behaviour

Small comments already :
* We don't put change logs in the files themselves, but in the global ChangeLog specifying what files/functions were changed (have a look at it for examples of how it's used).
* We don't need patches for generated files like Makefile.in or configure, only supply the modifications to Makefile.am or configure.ac.
* If you're adding configure options (like "OPTIMIZE"), document what it does
Comment 4 Jason Zhao 2007-10-18 01:14:12 UTC
Hi Edward, 

As we are the first time to do it, can you give us some guide?
We will split up our patch into small patchs. but we are not familiar with the rule of bug. 

From your mail, by my understanding, we could submit more bugs than just one.
each bug describes one part of change. is it correct for my understanding?
Comment 5 Edward Hervey 2007-10-18 07:15:11 UTC
Hi Jason. Indeed, it's much better to submit more individual bugs that one big one that fixes many things.

As a small example, the patch regarding gstbasesink should go in a separate bug, with a patch for only those gstbasesink-related files. Don't forget to explain why you wrote that patch, what extra features (or bugfixes) it brings, etc...
Comment 6 Jason Zhao 2007-10-18 07:21:12 UTC
Hi Edward, We will do it.
By the way, Did you remember your trip to Beijing Motorola early this year? we got much benefit from you. Thank you very much, if we have more questions, would you help us?
Comment 7 Edward Hervey 2007-10-18 07:26:51 UTC
I do remember the trip indeed :) As for answering your questions... that's what I've been doing currently. Don't hesitate also to use the other means of communication available to ask questions/participate in the GStreamer community:

Mailing-list : gstreamer-devel@lists.sourceforge.net
IRC : #gstreamer on irc.freenode.net

Changing the status of the bug to NEEDINFO until you create the other smaller bugs, then we can close this bug.
Comment 8 Jason Zhao 2007-10-23 06:06:14 UTC
I have splited patch into 4 bugs: 489268, 489269, 489270, 489275.
pls check these bugs for detailed information.