After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 486636 - "Cannot open display" message doesn't include display when set via $DISPLAY
"Cannot open display" message doesn't include display when set via $DISPLAY
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
2.12.x
Other Linux
: Normal trivial
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2007-10-14 17:58 UTC by Loïc Minier
Modified: 2007-10-15 13:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes "cannot open display" error message when display is set by env var (608 bytes, patch)
2007-10-14 18:01 UTC, Loïc Minier 		committed Details | Review

Description Loïc Minier 2007-10-14 17:58:35 UTC 
Hi,

Mike Hommey reported in Debian bug http://bugs.debian.org/283076 that when opening of a display fails and the display was set via the $DISPLAY env var, the message doesn't include the display name; e.g. DISPLAY=:1 gedit gives:
cannot open display: 

I'll attach his patch.

Bye,
Comment 1 Loïc Minier 2007-10-14 18:01:07 UTC 
Created attachment 97219 [details] [review]
Fixes "cannot open display" error message when display is set by env var
Comment 2 Matthias Clasen 2007-10-14 18:58:18 UTC 
Looks fine; might also fix the final fallback text to be "" instead of " ".
Comment 3 Loïc Minier 2007-10-15 13:27:46 UTC 
Commited to trunk with s/" "/""/ as r18909:

2007-10-15  Loïc Minier  <lool@dooz.org>

        * gtk/gtkmain.c: (gtk_init): Fix "cannot open display" error message
        when display is set by the DISPLAY env var. (#486636, Mike Hommey)