GNOME Bugzilla – Bug 485730
Better labels for remove/move to trash
Last modified: 2010-09-01 12:43:12 UTC
From https://bugzilla.redhat.com/show_bug.cgi?id=248367 ---8<--- When removing a track from a playlist by right-clicking on it, there are two relevant menu entries: * Remove * Move to Wastebasket It is not clear what the difference is. In fact, 'Move to Wastebasket' will actually move the *original track* from your Library(!!), whereas Remove will do the right thing and remove the track from the playlist (but keep the Library as-is). This is very confusing, and will lead to people unintentionally losing tracks from their Library. Steps to Reproduce: 1.Create a playlist 2.Add a track to the playlist from the Library 3.Right-click on the track in the playlist 4.Try to decide what the opposite of step 2 is from the menu entries given Actual results: 'Move to Wastebasket' is selected, no confirmation required, track is removed from Library. Expected results: F-Spot is an example of an application that does this sort of thing much better. ---8<--- ---8<--- The F-Spot menu items read: Remove From Catalogue Delete From Drive ---8<--- I think we should use, as appropriate: Remove from playlist Remove from library (or maybe Ignore?) Delete from Drive (the implementation detail being that it goes to the wastebasket)
Created attachment 131589 [details] [review] Patch for bug 485730 The right-click menu has been modified for both the playlist and the library browser. The generic remove option remains for other uses as in radio station's lists. The playlist viewer now features a 'remove from playlist' option and the library browser has the option 'ignore' to ignore the particular file to be included in the library. The 'Move to Wastebasket' is now labeled as 'Delete from Drive' and will move the actual file to the Trash. Changelog: *rhythmbox-ui.xml *rb-shell-clipboard.c
"Ignore Selection" isn't a good description for what it does. It's not technically correct, and I don't think it'd mean anything to anyone not already familiar with how the library works. I don't like "delete from drive" much either. What's a drive?
Created attachment 131993 [details] [review] Patch for bug 485730 : Updated The patch has been updated with the following changes: 1. For removing media from library ( ignoring media files ) the option has been labeled : Remove from Library ( same for multiple selection ) 2. For deleting files from disk : Delete file ( suggestion: Delete from disk ). For multiple selection : Delete files All other changes remain same.
Please don't include local hacks like the changes to eggdesktopfile.c in patches you submit to bugzilla.
The tooltips for these actions should all be in sentence case, not title case (that is, only the first word should be capitalised). The tooltips should be a bit more descriptive here too. They're displayed in the status bar of the main window, so there's plenty of room to describe the action in full. The tooltip for the 'QueueDelete' action should be updated too. Something like "Remove the selected songs from the playlist"; "Remove the selected songs from the library and all playlists"..
Created attachment 132246 [details] [review] Updated patch for 485730 Changes: 1. Generic removie tooltip : Remove the current selection 2. Remove from playlist : Remove the selected song(s) from the playlist 3. Remove from library : Remove the selected song(s) from the library 4. Delete file : Delete the selected file(s) from disk 5. QueueDelete : "Remove From Queue" Remove the selected song(s) from the play queue 6. The play queue when not in sidebar has different menu options then when in the sidebar: Has EditDelete ( Generic Remove option ) instead of the QueueDelete : Changed to EditRemove ( QueueDelete cannot be used : Comes up as grayed out : When not in sidebar the play queue acts like a playlist. Need help on this ) Does not have Clear Queue : Included the Clear Queue option 7. Removed the eggdesktopfile.c hack
If it seems like I'm picking a lot of nits here, it's because this is a nit picky bug to begin with. - <menuitem name="DeleteLibraryPopup" action="EditDelete"/> + <menuitem name="DeleteLibraryPopup" action="EditIgnore"/> The action shouldn't be called EditIgnore. EditRemoveLibrary might be more appropriate, and the other one should be EditRemovePlaylist for consistency. I was going to say that 'from' in 'Remove From Library' shouldn't be capitalized, but interestingly the HIG says it should be. + N_("Remove the selected song(s) from the playlist"), I don't particularly like "the selected song(s)", but I don't like "the selected songs" either. Nautilus uses "each selected item" in a few similar places, which seems like a good wording to me - it doesn't really get the plurality of the selection wrong, and it subtly hints that multiple items can be selected. There are a few other actions that should be made consistent with the rest, if nothing else: EditPlaylistAddNew, AddToQueue, MusicProperties, QueueMusicProperties.
*** Bug 536847 has been marked as a duplicate of this bug. ***
*** Bug 331018 has been marked as a duplicate of this bug. ***
*** Bug 579865 has been marked as a duplicate of this bug. ***
fixed somewhere between commits f40432fb255b31c29f72f889cfbfe2fe4f68afef and ae693e0592156bd4a160284e5c1bca1214523f59.
Now (0.13.0) we have this: Add to Play Queue Add to Playlist > Copy Cut --- Remove From Playlist Move to Wastebasket --- Properties But "Remove From Playlist" (i.e. I don't want to play that song right now, or on this playlist) is right next to "Move to Wastebasket" (i.e. I never want to hear that song again), with no separator. I think there should either be a separator, and/or there should be a confirmation dialog for Move to Wastebasket. Stepping back a second, do people really move tracks to the Wastebasket straight from a playlist? Can we just get rid of that (dangerous) option altogether?