GNOME Bugzilla – Bug 484306
Icon alignment in vertical button lists
Last modified: 2009-09-05 01:27:00 UTC
While the HIG doesn't mention this specifically, I find it more aesthetically pleasing when icons are aligned in a vertical list of buttons, similar to what you'd see on a menu. I think it's in the spirit of what the HIG *does* say about vertical alignment. Look at the attached screenshots of Evolution's "Message Filters" dialog, for example. I think the second screenshot makes the dialog look much more polished. This kind of thing is of course Srini's domain, so I'll defer to him to decide whether or not we should do this. If he agrees, I can use this bug as a tracker for fixing up other dialogs in Evolution. p.s. Is there any reason why we couldn't reinstate the UI category in Bugzilla for widget or HIG-related issues like this? Or does it tend to attract too many crazy ideas from users?
Created attachment 96793 [details] Screenshot: Message Filters (Before)
Created attachment 96794 [details] Screenshot: Message Filters (After)
Created attachment 97100 [details] [review] Patch for Message Filters / Search Folders dialogs It would probably help if I attached the patch... The patch is just Glade changes. I opened it in Glade 3 so of course it rewrote a bunch of stuff, but the manual changes are limited to the dialog buttons.
I have a script for you that might help if you know what to change manually :) anyway, I fill it's appropriate for this dialog because of the number of buttons but then what happens to the other ton of dialogs evolution has and where content of buttons are centered ?
(In reply to comment #4) > I have a script for you that might help if you know what to change manually :) Please attach it for email me directly. I'd appreciate it. > anyway, I fill it's appropriate for this dialog because of the number of > buttons but then what happens to the other ton of dialogs evolution has and > where content of buttons are centered ? The patch is just a sample. If Srini approves it, I'll use this bug as a tracker for fixing the rest of the dialogs. Feel free to help out if you want.
Matthew, I think it is fine to go this way. I don't have to review this. Just be cautious on the commits though :)
Thanks Srini. I'll fix up some other dialogs and post screenshots here before committing this. I'd rather commit everything at once to make sure we keep the UI consistent.
Matt, do you have a list of other dialogs to be improved? This task could be taken up by NOSIP students to get comfortable with the code.
Yeah, this one kind of got away from me. I'd say start by rummaging through all the Glade files in Evolution and libedataserverui. Those are easiest to fix. Then we can look for any hand-coded dialogs that still need fixing.
Oh, and for this bug, patches should be accompanied by before and after screenshots for each dialog.
Setting the patch status to Obsolete for now so it doesn't attract attention. Haven't gotten around to seeing this through yet, and I want to have /all/ the changes ready to go before we commit anything. The patch is still valid but incomplete, and was meant to just to get the ball rolling.
Given the decision to default to icon-free buttons throughout the desktop, I don't think it makes sense to pursue this anymore. Closing as WONTFIX.