After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 483301 - iconv-detect.c does not compile with -Wall -Werror
iconv-detect.c does not compile with -Wall -Werror
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Mailer
unspecified
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-10-04 10:33 UTC by Philip Van Hoof
Modified: 2007-10-09 17:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (737 bytes, patch)
2007-10-04 10:34 UTC, Philip Van Hoof 		none Details | Review

Description Philip Van Hoof 2007-10-04 10:33:12 UTC 
This makes it impossible to compile your application with these flags.

Will attach a patch that fixes this.
Comment 1 Philip Van Hoof 2007-10-04 10:34:15 UTC 
Created attachment 96622 [details] [review]
Patch
Comment 2 Matthew Barnes 2007-10-04 12:26:10 UTC 
I think this is already fixed in trunk.

http://svn.gnome.org/viewcvs/evolution-data-server/trunk/iconv-detect.c?r1=6236&r2=7668
Comment 3 Matthew Barnes 2007-10-04 12:35:37 UTC 
I take that back slightly -- the unused 'bits' variable is still there.
Comment 4 Philip Van Hoof 2007-10-05 10:51:27 UTC 
Ok, so somebody with reviewing powers remove the 'bits' variable and commit that, and close this bug :)
Comment 5 Matthew Barnes 2007-10-09 17:20:54 UTC 
I removed the 'bits' variable and marked your patch as 'obsolete'.

I think that should do it but feel free to re-open this bug if you still get a compiler warning.  Thanks for the patch; I'm looking forward to the day when we can compile evolution-data-server with those settings.