After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 482504 - Missing locale to UTF-8 conversion for modification time in filechooser
Missing locale to UTF-8 conversion for modification time in filechooser
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
2.12.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2007-10-02 08:54 UTC by Loïc Minier
Modified: 2007-10-04 07:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix warnings and display of modified date / time in filechooser for some locales as it was missing a locale to UTF-8 conversion (654 bytes, patch)
2007-10-02 08:56 UTC, Loïc Minier 		committed Details | Review

Description Loïc Minier 2007-10-02 08:54:33 UTC 
Hi,

As reported in Debian bug http://bugs.debian.org/444927, the filechooser will cause warnings in some locales for some dates.

The filechooser misses a conversion from locale to UTF-8 for the strftime() output which is in locale encoding.  I'll attach a patch.

Bye,
Comment 1 Loïc Minier 2007-10-02 08:56:54 UTC 
Created attachment 96501 [details] [review]
Fix warnings and display of modified date / time in filechooser for some locales as it was missing a locale to UTF-8 conversion
Comment 2 Matthias Clasen 2007-10-04 04:48:27 UTC 
Looks fine to me.
Comment 3 Loïc Minier 2007-10-04 07:41:47 UTC 
Committed to trunk as r18880:

2007-10-04  Loïc Minier  <lool@dooz.org>

       * gtk/gtkfilechooserdefault.c: (list_mtime_data_func): Fix warnings
       and display of modified date / time in filechooser for some locales as
       it was missing a locale to UTF-8 conversion. Fixes #482504.