GNOME Bugzilla – Bug 482159
Should not allow to use Ctrl+V to paste in the Leave Message box
Last modified: 2014-02-21 21:06:11 UTC
This bug has been filled here: https://bugs.launchpad.net/ubuntu/+source/gnome-screensaver/+bug/146862 "Pressing Ctrl+V while leaving a message pastes the contents of the clipboard. As the session is locked, should potentially anybody be able to see what's on your clipboard?"
Created attachment 98517 [details] Maybe this is enaough to confirm the bug I copied the text from the main page of this bug from bugzill.gnome.org then locked the screen tried to keep a message for myself and pressed ctrl+v in the message box...it pasted text.
Attached screenshot .png as..Maybe that will confirm this bug. I copied the text from the main page of this bug from bugzill.gnome.org then locked the screen tried to keep a message for myself and pressed ctrl+v in the message box...it pasted text.
*** Bug 483424 has been marked as a duplicate of this bug. ***
*** Bug 501122 has been marked as a duplicate of this bug. ***
Confirmed with gnome-screensaver 2.20.0 on Ubuntu Gutsy.
*** Bug 503005 has been marked as a duplicate of this bug. ***
I've changed it to clear the primary and clipboard selections before showing the dialog. I think this is a reasonable thing to do since the locked screen implies that the user has been away for a while and has already interrupted their workflow. The only other option I think is to block the paste action for every possible input widget. Which doesn't seem as nice. One thing that wasn't obvious to me is why clipboard_clear doesn't actually unset the selection - you have to set a new one to do that. Anyway, fixed in 2.20 and trunk.
(In reply to comment #7) > I've changed it to clear the primary and clipboard selections before showing > the dialog. I think this is a reasonable thing to do since the locked screen > implies that the user has been away for a while and has already interrupted > their workflow. The only other option I think is to block the paste action for > every possible input widget. Which doesn't seem as nice. Thanks for fixing this, but I'm not sure if this is the optimal solution. The screensaver and the clipboard really have nothing to do with each other and I think the one shouldn't mess with the other if it is avoidable. While you are probably right that most users don't care about the contents of the clipboard after locking the screen, it is possible come up with use cases where they might. What's wrong with just blocking the paste action?
Or optionally, how about getting the contents and setting them back after the screen was unlocked? I agree with Turtiainen in that there are cases where you might care about the contents after locking the screen. For example, what if you're idle and screensaver timeout values aren't high (usually on laptops), and the screensaver was just turned on while you were idle or talking with somebody; you probably wanted to continue working...
This is a kind of data loss. If this fix is kept the way it is presently, some day or other ..smbdy(not me) will file another Bug to fix the fix. Both the alternatives provided are good. -Sri
Can someone comment on how this bug was fixed?
Jelle Geerts: it was fixed badly (introduces a data loss bug).
*** Bug 527341 has been marked as a duplicate of this bug. ***
I do not see this as a permanent fix. I think either a new bug as a result of the fix needs raising or this fix changing to block any cut / paste / clipboard functionality whilst locked. Which resumes after unlock.
(In reply to comment #14) > I do not see this as a permanent fix. I think either a new bug as a result of > the fix needs raising or this fix changing to block any cut / paste / clipboard > functionality whilst locked. Which resumes after unlock. This would be bug 564165, bug 522386 or bug 522537.
*** Bug 564165 has been marked as a duplicate of this bug. ***
This is causing us problems with Ubuntu VirtualBox guests with the shared clipboard enabled. When the guest screen saver triggers, clearing the guest clipboard also clears the host one. Give that the "Leave a message" feature, which this was designed to protect, was removed three and a half years ago, would it be possible to revert the clipboard clearing patch now? Of course I can provide a reverting patch if that helps, but I doubt that will really do much for you.
gnome-screensaver hasn't been maintained for years.
I realise it is not being used with standard GNOME 3, but Ubuntu are using it, and it is still being updated on occasion in git. If someone can revert the change I will poke them to try to get them to import it.
In any case commenting in a close bug is really frowned upon. If there is an issue with this please open a new bug and just mention this one.