After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 481681 - Distclean of legal.xml and *.kbd files
Distclean of legal.xml and *.kbd files
Status: RESOLVED FIXED
Product: gok
Classification: Deprecated
Component: build
1.3.x
Other Linux
: Normal normal
: ---
Assigned To: David Bolter
David Bolter
Depends on:
Blocks:
 
 
Reported: 2007-09-29 20:43 UTC by Loïc Minier
Modified: 2008-06-25 19:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't distclean legal.xml (268 bytes, patch)
2007-09-29 20:44 UTC, Loïc Minier 		committed Details | Review
Remove *.kbd files in clean instead of distclean (549 bytes, patch)
2007-09-29 21:00 UTC, Loïc Minier 		committed Details | Review

Description Loïc Minier 2007-09-29 20:43:18 UTC 
Hi,

As a Debian QA effort, packages were rebuilt twice in a row (build + clean + build); this exposed a couple of issues in gok as described in Debian bug http://bugs.debian.org/441705.

I'll try to propose patches for the changes attached to this report starting with not distcleaning legal.xml.

Bye,
Comment 1 Loïc Minier 2007-09-29 20:44:57 UTC 
Created attachment 96382 [details] [review]
Don't distclean legal.xml

I make distchecked (without the docs/ dir as it seems to cause make distcheck failures) successfully with the patch applied, and the tarball shipped legal.xml.
Comment 2 Loïc Minier 2007-09-29 20:59:03 UTC 
Updating status to reflect the other distclean problem with *.kbd files.
Comment 3 Loïc Minier 2007-09-29 21:00:30 UTC 
Created attachment 96384 [details] [review]
Remove *.kbd files in clean instead of distclean

Attached patch helps distclean here and distcheck still passes in a similar way; please don't use the fix proposed in the Debian bug which causes distcheck to fail (files aren't make uninstalled properly).
Comment 4 David Bolter 2007-10-01 13:32:50 UTC 
Great work! Please commit. Reassign to yourself and close if you like.
Comment 5 Loïc Minier 2007-10-01 13:42:25 UTC 
Committed to trunk as r2446:

2007-10-01  Loïc Minier <lool@dooz.org>

       * help/gok/C/Makefile.am: Don't distclean legal.xml
       * Makefile.am: Remove *.kbd files in clean instead of distclean

       Helps distcheck; fixes bug #481681.